VersionControl:PRs/magenta/426 - Revision history

DrivingThatTrain: cryptograss/magenta#426, as GitHub has it

2026-11-09T16:06:20Z

cryptograss/magenta#426, as GitHub has it

← Older revision		Revision as of 16:06, 9 November 2026
Line 16:		Line 16:
	\|deploy=redeploy maybelle (before or with maybelle-config#286; until this is live, githouse refuses every merge order, which is the safe way round)		\|deploy=redeploy maybelle (before or with maybelle-config#286; until this is live, githouse refuses every merge order, which is the safe way round)
	}}		}}
			<pre class="pr-body">githouse asks memory-lane, before every merge order, whether AZ5 is on and whether the signer is banned. This is memory-lane's half of that; githouse's half is on maybelle-config#286.

			`GET /api/brakes/?name=justin&name=skyler` answers `{"scram": false \| {who pulled it}, "banned": {"justin": false, "skyler": false}}`.

			- githouse merges only on an explicit `false` for both, and refuses when there's no answer or a name is left out. So this endpoint can stop a merge but never make one.
			- It's answered during AZ5 too: AZ5 locks writes, and this is a read.
			- Anyone can read it. An AZ5 and a ban are both announced in #general anyway, and it only answers for names you ask about (at most 20, each as the inventory spells it).

			Why (Plan, section 10): removing someone from the GitHub org stops them merging today. githouse pushes with its own deploy key, so once merges go through githouse, the org no longer stops anyone. A ban has to stop them instead.

			Tests: three new tests in `test_mood_admin.py`: a ban and an unban are heard, AZ5 is heard while it holds, and bad questions are refused. Full suite: 1766 tests, OK.

			Deploy: redeploy maybelle (before or with maybelle-config#286; until this is live, githouse refuses every merge order, which is the safe way round)
			Worked on by: magent, justin, re, in #ramp</pre>

DrivingThatTrain: cryptograss/magenta#426, as GitHub has it

2026-11-08T02:05:22Z

cryptograss/magenta#426, as GitHub has it

← Older revision		Revision as of 02:05, 8 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/426		\|url=https://github.com/cryptograss/magenta/pull/426
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/githouse-brakes		\|branch=magent/githouse-brakes
	\|opened=2026-11-08 00:22:14		\|opened=2026-11-08 00:22:14
	\|pushed=2026-11-08 00:28:48		\|pushed=2026-11-08 00:28:48
	\|merged=		\|merged=2026-11-08 02:05:19
	\|closed=		\|closed=
	\|worked_on_by=magent, justin, re		\|worked_on_by=magent, justin, re

DrivingThatTrain: cryptograss/magenta#426, as GitHub has it

2026-11-08T00:28:59Z

cryptograss/magenta#426, as GitHub has it

← Older revision		Revision as of 00:28, 8 November 2026
Line 9:		Line 9:
	\|branch=magent/githouse-brakes		\|branch=magent/githouse-brakes
	\|opened=2026-11-08 00:22:14		\|opened=2026-11-08 00:22:14
	\|pushed=2026-11-08 00:21:32		\|pushed=2026-11-08 00:28:48
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#426, as GitHub has it

2026-11-08T00:22:18Z

cryptograss/magenta#426, as GitHub has it

New page

{{PR
|repo=magenta
|number=426
|title=memory-lane: /api/brakes/, what githouse asks before every merge
|url=https://github.com/cryptograss/magenta/pull/426
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/githouse-brakes
|opened=2026-11-08 00:22:14
|pushed=2026-11-08 00:21:32
|merged=
|closed=
|worked_on_by=magent, justin, re
|moods=ramp
|deploy=redeploy maybelle (before or with maybelle-config#286; until this is live, githouse refuses every merge order, which is the safe way round)
}}