VersionControl:PRs/magenta/434 - Revision history

DrivingThatTrain: cryptograss/magenta#434, as GitHub has it

2026-11-09T19:43:12Z

cryptograss/magenta#434, as GitHub has it

← Older revision		Revision as of 19:43, 9 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/434		\|url=https://github.com/cryptograss/magenta/pull/434
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/clip-enter-sound		\|branch=magent/clip-enter-sound
	\|opened=2026-11-08 17:06:27		\|opened=2026-11-08 17:06:27
	\|pushed=2026-11-08 17:06:13		\|pushed=2026-11-08 17:06:13
	\|merged=		\|merged=2026-11-09 19:43:08
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin

DrivingThatTrain: cryptograss/magenta#434, as GitHub has it

2026-11-09T16:06:18Z

cryptograss/magenta#434, as GitHub has it

← Older revision		Revision as of 16:06, 9 November 2026
Line 16:		Line 16:
	\|deploy=redeploy maybelle		\|deploy=redeploy maybelle
	}}		}}
			<pre class="pr-body">Justin couldn't send a message that was only a clip name by pressing Enter.

			Why: once the name you've typed matches a clip suggestion exactly, the list stays open. Enter then "accepted" that suggestion, which put back the same text and reopened the list, so the message never went out. Now, if the highlighted suggestion is exactly what's already typed, Enter closes the list and sends.

			Also, people can now type `/clip <name>` as well as `/clips <name>`. Emergents could already use both (`AGENT_PLAY`). Before this, a person's `/clip <name>` was posted as plain text.

			Not changed: the sound. I downloaded `whats-the-meaning-of-this` from `/clips/c4c2f446…/`, the same media the Mood's player uses. ffprobe shows an AAC stereo track, and volumedetect gives a mean of −21 dB, mostly centre (speech-like). So the cut has sound, and the cause is somewhere else.

			Tests: added `test_a_person_may_say_clip_too`. `test_clips_library` and `test_own_clips` pass (20 tests, sqlite). I haven't run the full suite.

			Deploy: redeploy maybelle
			Worked on by: magent and justin, in #clips</pre>

DrivingThatTrain: cryptograss/magenta#434, as GitHub has it

2026-11-08T17:06:32Z

cryptograss/magenta#434, as GitHub has it

New page

{{PR
|repo=magenta
|number=434
|title=Clips: Enter sends a fully typed clip name; /clip works for people
|url=https://github.com/cryptograss/magenta/pull/434
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/clip-enter-sound
|opened=2026-11-08 17:06:27
|pushed=2026-11-08 17:06:13
|merged=
|closed=
|worked_on_by=magent, justin
|moods=clips
|deploy=redeploy maybelle
}}