VersionControl:PRs/magenta/446 - Revision history

DrivingThatTrain: cryptograss/magenta#446, as GitHub has it

2026-11-09T16:06:13Z

cryptograss/magenta#446, as GitHub has it

← Older revision		Revision as of 16:06, 9 November 2026
Line 16:		Line 16:
	\|deploy=redeploy maybelle (memory-lane; has a migration)		\|deploy=redeploy maybelle (memory-lane; has a migration)
	}}		}}
			<pre class="pr-body">Plan section 8's 👍: any signed-in person's "I like this", shown on the ramp beside each open piece of work. It's a signal only. githouse never asks for one, and a press merges nothing.

			- What's kept: one press records who, when and which commit (new table `ramp_thumbs`, migration 0050). Pressing again takes the 👍 back.
			- It's on a commit, not a name. `POST /api/ramp/thumb/` accepts only the head githouse has now, and answers 409 otherwise. So a 👍 is always on what the presser saw. Once the branch moves, the ramp shows it as "(older commit)". A person who likes the new head too shows once, on the newer commit.
			- Who can press: any signed-in person, at either tier (key or PickiPedia). Not an emergent, and not someone who is signed out; signed-out viewers still see the count and the names. Limited to 30 presses a minute, and refused while the scram is set.
			- A branch that only GitHub has goes by its pull request's head, but only if that pull request's card names the same branch.

			Tests: `test_ramp_thumbs.py`, 7 of them. The full suite passes: 1810 tests OK. I didn't check it in a browser against the live data; the page test checks the HTML for both a signed-in and a signed-out viewer.

			Deploy: redeploy maybelle (memory-lane; has a migration)
			Worked on by: magent, justin, in #ramp</pre>

DrivingThatTrain: cryptograss/magenta#446, as GitHub has it

2026-11-09T15:27:27Z

cryptograss/magenta#446, as GitHub has it

← Older revision		Revision as of 15:27, 9 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/446		\|url=https://github.com/cryptograss/magenta/pull/446
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/ramp-thumbs		\|branch=magent/ramp-thumbs
	\|opened=2026-11-09 11:13:58		\|opened=2026-11-09 11:13:58
	\|pushed=2026-11-09 11:13:40		\|pushed=2026-11-09 11:13:40
	\|merged=		\|merged=2026-11-09 15:27:23
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin

DrivingThatTrain: cryptograss/magenta#446, as GitHub has it

2026-11-09T12:06:12Z

cryptograss/magenta#446, as GitHub has it

← Older revision		Revision as of 12:06, 9 November 2026
Line 14:		Line 14:
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin
	\|moods=ramp		\|moods=ramp
	\|deploy=redeploy ~~hunter~~ (memory-lane; has a migration)		\|deploy=redeploy maybelle (memory-lane; has a migration)
	}}		}}

DrivingThatTrain: cryptograss/magenta#446, as GitHub has it

2026-11-09T11:14:03Z

cryptograss/magenta#446, as GitHub has it

New page

{{PR
|repo=magenta
|number=446
|title=The 👍 on the ramp (Plan, section 8)
|url=https://github.com/cryptograss/magenta/pull/446
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/ramp-thumbs
|opened=2026-11-09 11:13:58
|pushed=2026-11-09 11:13:40
|merged=
|closed=
|worked_on_by=magent, justin
|moods=ramp
|deploy=redeploy hunter (memory-lane; has a migration)
}}