DrivingThatTrain: cryptograss/magenta#449, as GitHub has it

2026-11-09T16:37:30Z

cryptograss/magenta#449, as GitHub has it

← Older revision		Revision as of 16:37, 9 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/449		\|url=https://github.com/cryptograss/magenta/pull/449
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/work-followups		\|branch=magent/work-followups
	\|opened=2026-11-09 15:54:44		\|opened=2026-11-09 15:54:44
	\|pushed=2026-11-09 15:59:34		\|pushed=2026-11-09 15:59:34
	\|merged=		\|merged=2026-11-09 16:37:25
	\|closed=		\|closed=
	\|worked_on_by=magent, justin, re		\|worked_on_by=magent, justin, re

DrivingThatTrain: cryptograss/magenta#449, as GitHub has it

2026-11-09T16:01:17Z

cryptograss/magenta#449, as GitHub has it

← Older revision		Revision as of 16:01, 9 November 2026
Line 9:		Line 9:
	\|branch=magent/work-followups		\|branch=magent/work-followups
	\|opened=2026-11-09 15:54:44		\|opened=2026-11-09 15:54:44
	\|pushed=2026-11-09 15:54:22		\|pushed=2026-11-09 15:59:34
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#449, as GitHub has it

2026-11-09T15:54:49Z

cryptograss/magenta#449, as GitHub has it

New page

{{PR
|repo=magenta
|number=449
|title=Work pages, round two: comments whole in the Mood, one merged line, ramp links to pages, ask dots, a merge sheet per Mood
|url=https://github.com/cryptograss/magenta/pull/449
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/work-followups
|opened=2026-11-09 15:54:44
|pushed=2026-11-09 15:54:22
|merged=
|closed=
|worked_on_by=magent, justin, re
|moods=ramp
|deploy=redeploy maybelle (memory-lane; no migrations)
}}
<pre class="pr-body">Justin's notes on #446–#448, from #ramp (9 Nov):

**1. A comment on a work's page is said whole in its Mood, and a reply there shows on the page.**
- The Mood's "💬" line for a work's page carries the comment's text, and the Mood draws it rendered (same renderer as Tiding comments, so it's escaped the same way).
- A ↩ reply to that line in the Mood shows under the comment on the page, marked "in #ramp", and can be answered from the page.
- An emergent's answer to an @ask is already copied onto the page as a comment, so its Mood reply isn't shown a second time.
- When a comment is edited or deleted, its Mood line follows, so text sealed away on delete doesn't stay visible in the Mood.
- Other Tidings keep the one-line notice they have now.

**2. The merge sheet covers only its Mood's pane, one sheet per Mood.**
- On the one page, the sheet covers `#main` only. The header, the Moods list and the to-do rail stay usable.
- Switching Moods hides it, and coming back shows it as it stands. A press in progress keeps polling while you're away.
- Opening a section (Tidings, the ramp…) hides it too.
- On the ramp and on a work's page it still covers that page, as before.

**3. A merge done with the button is said once in the Mood, by branch.**
- The webhook's PR line (`todo.announce_merge`) is skipped in the Mood where a merge order for that branch was pressed within the last two days. The button's own line (`merge_orders.announce`) stands.
- Moods that list the PR without having pressed Merge still get the PR line.

**4. The ramp's work names link to each work's page.**
- If the work has a page, its name links to it. If not, a signed-in person's click opens one and goes there; a modifier-click still opens GitHub.
- GitHub stays as a small ↗ beside the name.
- Signed out, the name still links to GitHub.
- Merged work links its page too, if it had one.

**5. Ask dots, and who wants it on the sheet.**
- The "🪢 asked" badge is now "● ● asked": one dot per emergent with an open merge ask, in that emergent's colour, each a link to its ask.
- The colours come from a server-side copy of the Moods page's own (`front.agent_colour`).
- The merge sheet shows the same dots plus the 👍s. A 👍 given on an older commit says so.
- The work page shows the dots too.

**Also fixed:** the Mood's "opened a page to talk about…" line said "a piece of work", because `ref` wasn't in the event fields `views_moods` passes on.

**Tests:** `test_work_followups.py` (11) and `AskDotsTest` in `test_ramp.py` (4) are new. The full suite passes: 1859 tests OK.

**Checked in Playwright** on a local memory-lane reading githouse's real copy, signed in as a local test device with a throwaway merge key (nothing pressed):
- A comment with a list, bold and `print("<script>")` drew whole in #ramp, escaped.
- A ↩ reply to it in #ramp showed under it on the page.
- `/merge magenta#347` opened the sheet over exactly the Mood pane (same box as `#main`). It hid on going to #interfaces and was back on returning.
- The ramp row showed re's and blu's dots, and the sheet listed "🪢 asked: re, blu" and "👍 skyler (older commit), justin".

Deploy: redeploy maybelle (memory-lane; no migrations)
Worked on by: magent, justin, re, in #ramp</pre>

VersionControl:PRs/magenta/449 - Revision history

DrivingThatTrain: cryptograss/magenta#449, as GitHub has it

DrivingThatTrain: cryptograss/magenta#449, as GitHub has it

DrivingThatTrain: cryptograss/magenta#449, as GitHub has it