VersionControl:PRs/magenta/452 - Revision history

DrivingThatTrain: cryptograss/magenta#452, as GitHub has it

2026-11-09T20:33:03Z

cryptograss/magenta#452, as GitHub has it

← Older revision		Revision as of 20:33, 9 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/452		\|url=https://github.com/cryptograss/magenta/pull/452
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/ramp-urls		\|branch=magent/ramp-urls
	\|opened=2026-11-09 17:00:16		\|opened=2026-11-09 17:00:16
	\|pushed=2026-11-09 20:02:39		\|pushed=2026-11-09 20:02:39
	\|merged=		\|merged=2026-11-09 20:33:00
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin

DrivingThatTrain: cryptograss/magenta#452, as GitHub has it

2026-11-09T20:06:16Z

cryptograss/magenta#452, as GitHub has it

← Older revision		Revision as of 20:06, 9 November 2026
Line 52:		Line 52:

	Checked in a browser against a local server: Mood → candidate → Back gives the Mood; ramp → candidate → Back gives the ramp → Back gives the Mood → Forward gives the ramp. The full suite passes, 1,893 tests.		Checked in a browser against a local server: Mood → candidate → Back gives the Mood; ramp → candidate → Back gives the ramp → Back gives the Mood → Forward gives the ramp. The full suite passes, 1,893 tests.

			The ramp: sort by Mood, and a button for each person (`0804ab7`, Justin, #ramp 19:47Z).
			- Sort by "mood": Moods A to Z, then candidates with no Mood, each group newest first. A candidate's Moods come from its card; without a card, from where it was last said, shown in italics.
			- "Who:" buttons, one per person on an open candidate, most candidates first, emergents with their colour dot. Click a name once to see only candidates they're on (several names combine). Click again to hide their candidates, and again to clear it. "everyone" resets all of them. The page shows "N of M shown", and the choice is kept in your browser.
			- Who's on a candidate is read from its "Worked on by" line (asides such as "(testing on an iphone 17)" are dropped) plus its author. GitHub logins map to people (`jMyles` is justin). Run over the 51 live rows, it gave magent 39, justin 26, skyler 14, re 11, dependabot 6, blu 3, slvrbckt 2, with no stray words.

			Full suite: 1,896 tests pass. The filter and sort were checked in a browser on a rendered copy of the page.

	Deploy: redeploy maybelle (memory-lane); no migrations		Deploy: redeploy maybelle (memory-lane); no migrations
	Worked on by: magent, justin, in #interfaces, #ramp</pre>		Worked on by: magent, justin, in #interfaces, #ramp</pre>

DrivingThatTrain: cryptograss/magenta#452, as GitHub has it

2026-11-09T20:02:50Z

cryptograss/magenta#452, as GitHub has it

← Older revision		Revision as of 20:02, 9 November 2026
Line 9:		Line 9:
	\|branch=magent/ramp-urls		\|branch=magent/ramp-urls
	\|opened=2026-11-09 17:00:16		\|opened=2026-11-09 17:00:16
	\|pushed=2026-11-09 19:55:57		\|pushed=2026-11-09 20:02:39
	\|merged=		\|merged=
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin
	\|moods=interfaces		\|moods=interfaces, ramp
	\|deploy=redeploy maybelle (memory-lane); no migrations		\|deploy=redeploy maybelle (memory-lane); no migrations
	}}		}}
Line 44:		Line 44:
	- Back returns to `/ramp/` with its frame.		- Back returns to `/ramp/` with its frame.
	- `/moods/pulls/` lands on `/ramp/`.		- `/moods/pulls/` lands on `/ramp/`.

			Since then (9 Nov, #ramp): main merged in, and a candidate branch's page in the ramp (`ab5f080`).
			- main merged in. #451 and today's ramp work (candidates named alike, ± See the diff, the stale board, the merge sheet's full diff) now use these addresses. The conflicts listed above are resolved.
			- A candidate's page is `/ramp/<repo>/<branch>/`. Justin asked why the full diff took him to Tidings. It now opens in the ramp, and the nav highlights the ramp. The page is made the first time a signed-in person asks for it. The ramp's rows, the merge sheet's "± See the full diff", the Mood's work and comment lines, and a diff line's copied link all point there. Its old `/tidings/<id>/` address redirects there.
			- Back returns to where you came from. The ramp's frame is moved with `location.replace`, so it never adds a history step of its own. From a Mood's merge sheet, Back returns to the Mood. From the ramp, Back returns to the list.
			- `/moods/ramp/` is the Mood #ramp again. The old-address rule had read it as the ramp section, so Back into #ramp showed the ramp.

			Checked in a browser against a local server: Mood → candidate → Back gives the Mood; ramp → candidate → Back gives the ramp → Back gives the Mood → Forward gives the ramp. The full suite passes, 1,893 tests.

	Deploy: redeploy maybelle (memory-lane); no migrations		Deploy: redeploy maybelle (memory-lane); no migrations
	Worked on by: magent, justin, in #interfaces</pre>		Worked on by: magent, justin, in #interfaces, #ramp</pre>

DrivingThatTrain: cryptograss/magenta#452, as GitHub has it

2026-11-09T19:57:47Z

cryptograss/magenta#452, as GitHub has it

← Older revision		Revision as of 19:57, 9 November 2026
Line 9:		Line 9:
	\|branch=magent/ramp-urls		\|branch=magent/ramp-urls
	\|opened=2026-11-09 17:00:16		\|opened=2026-11-09 17:00:16
	\|pushed=2026-11-09 16:59:47		\|pushed=2026-11-09 19:55:57
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#452, as GitHub has it

2026-11-09T17:00:21Z

cryptograss/magenta#452, as GitHub has it

New page

{{PR
|repo=magenta
|number=452
|title=Sections at their own addresses (/ramp/, /tidings/…), the ramp beside polls, people's badge green
|url=https://github.com/cryptograss/magenta/pull/452
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/ramp-urls
|opened=2026-11-09 17:00:16
|pushed=2026-11-09 16:59:47
|merged=
|closed=
|worked_on_by=magent, justin
|moods=interfaces
|deploy=redeploy maybelle (memory-lane); no migrations
}}
<pre class="pr-body">Justin, 9 Nov (#interfaces).

**Addresses.** Only the Moods and threads are `/moods/…` now. The sections are at `/tidings/`, `/polls/`, `/ramp/` (was `/moods/pulls/`), `/prompts/`, `/status/`, `/todo/`, `/tasks/`, `/journals/`, `/verify/`, `/hooks/` and `/settings/`. A tiding is at `/tidings/<id>/`.
- Every old `/moods/<section>/` address, including `/moods/tidings/<id>/`, redirects with a 301 and keeps its query. Links in what's already been said still land.
- The one page's section routing (`sectionOf`, the frames, Back and Forward) uses the new paths. A link to an old address that is posted in a Mood or comes from inside a section still opens in place.
- The section is now named `ramp` everywhere, not `pulls`. The template is still `mood_pulls.html` so it doesn't conflict with #451.
- Not moved: the app's own files (`/moods/sw.js`, the manifest, the icons, `/moods/share/`, sign-in, media), a Mood's `/moods/<slug>/instructions/` and `/moods/<slug>/rules/`, and `/moods/tour/`.

**The app and the service worker.**
- The manifest's `scope` is now `/`, so an installed app opens the sections inside itself. Its `id` and `start_url` are unchanged, so it's still the same app.
- The service worker stays at `/moods/`, because the push subscriptions live on that registration. Moving it would drop everyone's notifications.
- Its push and notification-click checks now count a section page as an open magenta page, as `/moods/tidings/` counted before.
- iOS reads a home-screen app's scope only when it's installed. In-app section switches use pushState, so they stay in the app regardless.

**Top bar.** The ramp moved out of the ▾ menu and now sits after polls.

**Mood list.** The badge for people's messages is green (`--spoke-h`), matching the "a person spoke lately" glow. In dark mode it has dark text. Emergents' badges stay hollow magenta.

**Conflicts to expect.**
- #432 adds phone links to `/moods/pulls/` and other `/moods/…` sections.
- #451 edits `mood_pulls.html` and other files whose links this rewrites.

Whichever of these merges second needs those links rebased to the new paths.

**Tests:** new tests cover the old addresses redirecting and the ramp sitting beside polls. Every test that used the old paths now uses the new ones. Full suite: 1,866 ran; the one failure was a test with a doubly-escaped old path. That test is fixed and its module passes. Checked in a browser against a local server:
- Clicking ramp gives `/ramp/`, and polls gives `/polls/`.
- Back returns to `/ramp/` with its frame.
- `/moods/pulls/` lands on `/ramp/`.

Deploy: redeploy maybelle (memory-lane); no migrations
Worked on by: magent, justin, in #interfaces</pre>