VersionControl:PRs/magenta/453 - Revision history

DrivingThatTrain: cryptograss/magenta#453, as GitHub has it

2026-11-10T14:12:26Z

cryptograss/magenta#453, as GitHub has it

← Older revision		Revision as of 14:12, 10 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/453		\|url=https://github.com/cryptograss/magenta/pull/453
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/mood-list-candidates		\|branch=magent/mood-list-candidates
	\|opened=2026-11-09 17:00:20		\|opened=2026-11-09 17:00:20
	\|pushed=2026-11-10 14:04:32		\|pushed=2026-11-10 14:04:32
	\|merged=		\|merged=2026-11-10 14:12:20
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin

DrivingThatTrain: cryptograss/magenta#453, as GitHub has it

2026-11-10T14:06:20Z

cryptograss/magenta#453, as GitHub has it

← Older revision		Revision as of 14:06, 10 November 2026
Line 9:		Line 9:
	\|branch=magent/mood-list-candidates		\|branch=magent/mood-list-candidates
	\|opened=2026-11-09 17:00:20		\|opened=2026-11-09 17:00:20
	\|pushed=2026-11-~~09 16~~:59:50		\|pushed=2026-11-10 14:04:32
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#453, as GitHub has it

2026-11-10T14:04:13Z

cryptograss/magenta#453, as GitHub has it

← Older revision		Revision as of 14:04, 10 November 2026
Line 6:		Line 6:
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=open		\|state=open
	\|base=~~magent/candidates~~		\|base=main
	\|branch=magent/mood-list-candidates		\|branch=magent/mood-list-candidates
	\|opened=2026-11-09 17:00:20		\|opened=2026-11-09 17:00:20

DrivingThatTrain: cryptograss/magenta#453, as GitHub has it

2026-11-09T17:00:26Z

cryptograss/magenta#453, as GitHub has it

New page

{{PR
|repo=magenta
|number=453
|title=Mood list: a merge ask shows its candidate branch's name, with a dot per emergent asking
|url=https://github.com/cryptograss/magenta/pull/453
|author=magent-cryptograss
|state=open
|base=magent/candidates
|branch=magent/mood-list-candidates
|opened=2026-11-09 17:00:20
|pushed=2026-11-09 16:59:50
|merged=
|closed=
|worked_on_by=magent, justin
|moods=interfaces
|deploy=redeploy maybelle (memory-lane), after #451; no migrations
}}
<pre class="pr-body">Justin, 9 Nov (#interfaces): "instead of the badge for merge (the thread), show the name of the candidate branch from the ramp that is proposed, with the emergent color dots next to it for each emergent that has approved / asked for merge."

**Stacked on #451.** This builds on its per-ask list of unmerged candidates (`tools_ask.unmerged`, the `works` field). Merge #451 first; this PR then retargets to main.

- **In the Mood list:** each candidate a merge ask names shows as its branch's name in a small monospace chip, cut with … after 11em. Each emergent asking for that branch adds a dot in its colour. Hovering says the name, for example `magenta#451 (magent/candidates)`, and who asked. Two emergents asking about the same branch give one chip with two dots. Tools (🔨) and redeploy (🖥️) asks show as before.
- **Already merged:** once every candidate an ask names has merged, the ask shows nothing.
- **Branch names:** `unmerged` now adds a pull request's branch, read from the ramp's last board through `ramp.branch_of`. That reads only the cache and never builds a board, because a build takes seconds on maybelle. Before the ramp has been drawn, a candidate shows as `repo#N`.
- **"Approved":** for now the dots are the emergents' merge asks in that Mood. 👍s on the ramp come from people, so they aren't dots here.

**Tests:** `test_an_ask_carries_what_it_names_not_merged_yet` now expects the branch. `test_ramp` passes (33). I checked the chip's HTML by running `askGroups` in node: one chip per branch, a dot per emergent, merged ones dropped. I haven't looked at the list itself in a browser with real asks.

Deploy: redeploy maybelle (memory-lane), after #451; no migrations
Worked on by: magent, justin, in #interfaces</pre>