VersionControl:PRs/magenta/456 - Revision history

DrivingThatTrain: cryptograss/magenta#456, as GitHub has it

2026-11-10T04:32:16Z

cryptograss/magenta#456, as GitHub has it

← Older revision		Revision as of 04:32, 10 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/456		\|url=https://github.com/cryptograss/magenta/pull/456
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/voice-ask-pace		\|branch=magent/voice-ask-pace
	\|opened=2026-11-09 23:05:24		\|opened=2026-11-09 23:05:24
	\|pushed=2026-11-09 23:06:35		\|pushed=2026-11-09 23:06:35
	\|merged=		\|merged=2026-11-10 04:32:12
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin

DrivingThatTrain: cryptograss/magenta#456, as GitHub has it

2026-11-10T00:06:19Z

cryptograss/magenta#456, as GitHub has it

← Older revision		Revision as of 00:06, 10 November 2026
Line 2:		Line 2:
	\|repo=magenta		\|repo=magenta
	\|number=456		\|number=456
	\|title=Read aloud: an ask at the end ~~is the narrator's line~~, ~~not slow-played tag words~~		\|title=Read aloud: the pace holds for an ask at the end, and for a clip fetched ahead
	\|url=https://github.com/cryptograss/magenta/pull/456		\|url=https://github.com/cryptograss/magenta/pull/456
	\|author=magent-cryptograss		\|author=magent-cryptograss
Line 33:		Line 33:
	- Any other ask or gesture tag inside the message (`<merge/> <deploy/> <tools/> <react/> <wait/> <take/> <silent/>`) is dropped from what's read.		- Any other ask or gesture tag inside the message (`<merge/> <deploy/> <tools/> <react/> <wait/> <take/> <silent/>`) is dropped from what's read.

	~~Not~~ fixed here. re's message 554bc9c2 ~~was reported at~~ rate 1.0 ~~with~~ pace 0, ~~meaning the page couldn't read the clip's pace when it reported~~. That's a ~~different path~~. ~~It may be reported after~~ the ~~player had moved~~ on, ~~but I haven't confirmed that~~.		A second cause, also fixed here. Justin, 23:02Z: re's message after his memo was slow too. Its `heard` row (554bc9c2) shows rate 1.0 and pace 0.
			- A clip fetched ahead (`speakFetch(..., keep)`, used by `prefetchNext` while a memo is being recorded) was turned into a `blob:` URL. That dropped its `#words=…&who=…`.
			- `clipSays` took every `blob:` for a chime, so `rateFor` gave 1.
			- Now the fragment rides on the blob URL. A chime is recognised by having no `words`, not by being a blob.
			- Checked in Chromium (Playwright): a `blob:…#words=12&who=agent` WAV loads, and `currentSrc` keeps the fragment. Not checked in Safari.

	Tests: two new tests in `test_readback_pieces`: an ask becomes the narrator's aside, and a gesture in mid-message isn't read. Full suite: 1,910 ran. The only failures are the two `ReleaseTorrentTest` tests that re's branch `re/tiding-torrent-test-url` fixes on main.		Tests: for the first cause, two new tests in `test_readback_pieces`: an ask becomes the narrator's aside, and a gesture in mid-message isn't read. Full suite: 1,910 ran. The only failures are the two `ReleaseTorrentTest` tests that re's branch `re/tiding-torrent-test-url` fixes on main.

	Deploy: redeploy maybelle (memory-lane); no migrations		Deploy: redeploy maybelle (memory-lane); no migrations
	Worked on by: magent, justin, in #interfaces</pre>		Worked on by: magent, justin, in #interfaces</pre>

DrivingThatTrain: cryptograss/magenta#456, as GitHub has it

2026-11-09T23:06:44Z

cryptograss/magenta#456, as GitHub has it

← Older revision		Revision as of 23:06, 9 November 2026
Line 9:		Line 9:
	\|branch=magent/voice-ask-pace		\|branch=magent/voice-ask-pace
	\|opened=2026-11-09 23:05:24		\|opened=2026-11-09 23:05:24
	\|pushed=2026-11-09 23:05:11		\|pushed=2026-11-09 23:06:35
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#456, as GitHub has it

2026-11-09T23:05:29Z

cryptograss/magenta#456, as GitHub has it

New page

{{PR
|repo=magenta
|number=456
|title=Read aloud: an ask at the end is the narrator's line, not slow-played tag words
|url=https://github.com/cryptograss/magenta/pull/456
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/voice-ask-pace
|opened=2026-11-09 23:05:24
|pushed=2026-11-09 23:05:11
|merged=
|closed=
|worked_on_by=magent, justin
|moods=interfaces
|deploy=redeploy maybelle (memory-lane); no migrations
}}
<pre class="pr-body">Justin, 9 Nov (#interfaces): "the message after that read slowly, like as if it wasn't respecting the words per minute directive." This is the cause of item 6 from his 8 Nov memo, where later clips seemed slower.

**What the record shows.** These are the `heard` rows for magent's message 80170b4a, from Justin's Chrome PWA:
- Piece 1: pace 136, played at 1.61×, which is his 220 a minute.
- Piece 2: pace **240**, played at **0.92×**.

240 is the clamp's ceiling, so the page measured piece 2 as far faster than the voice speaks, then slowed it down.

**Why.** Piece 2 was "I checked that logic outside the page but haven't seen it on a phone." followed by `<merge to="magenta#455, voice bar still while recording"/>`.
- The page counts the words of what it sent: 21.
- ElevenLabs spoke only 14 of them. The tag wasn't read aloud.
- Asks always come at the end of a message, so the last piece is the one played slow.

**Fix** (in `voice.script_for`):
- Asks at the end (`trailing_asks`) are read the way the page shows them, as an aside in the narrator's voice (#454): "requested a merge for magenta number 455, voice bar still while recording".
- Any other ask or gesture tag inside the message (`<merge/> <deploy/> <tools/> <react/> <wait/> <take/> <silent/>`) is dropped from what's read.

**Not fixed here.** re's message 554bc9c2 was reported at rate 1.0 with pace 0, meaning the page couldn't read the clip's pace when it reported. That's a different path. It may be reported after the player had moved on, but I haven't confirmed that.

**Tests:** two new tests in `test_readback_pieces`: an ask becomes the narrator's aside, and a gesture in mid-message isn't read. Full suite: 1,910 ran. The only failures are the two `ReleaseTorrentTest` tests that re's branch `re/tiding-torrent-test-url` fixes on main.

Deploy: redeploy maybelle (memory-lane); no migrations
Worked on by: magent, justin, in #interfaces</pre>