VersionControl:PRs/magenta/462 - Revision history

DrivingThatTrain: cryptograss/magenta#462, as GitHub has it

2026-11-11T12:06:38Z

cryptograss/magenta#462, as GitHub has it

← Older revision		Revision as of 12:06, 11 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/magenta/pull/462		\|url=https://github.com/cryptograss/magenta/pull/462
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=magent/cand-line-ramp-mood		\|branch=magent/cand-line-ramp-mood
	\|opened=2026-11-10 16:05:56		\|opened=2026-11-10 16:05:56
	\|pushed=2026-11-11 10:13:22		\|pushed=2026-11-11 10:13:22
	\|merged=		\|merged=2026-11-11 10:15:49
	\|closed=		\|closed=
	\|worked_on_by=magent, justin		\|worked_on_by=magent, justin

DrivingThatTrain: cryptograss/magenta#462, as GitHub has it

2026-11-11T10:15:21Z

cryptograss/magenta#462, as GitHub has it

← Older revision		Revision as of 10:15, 11 November 2026
Line 9:		Line 9:
	\|branch=magent/cand-line-ramp-mood		\|branch=magent/cand-line-ramp-mood
	\|opened=2026-11-10 16:05:56		\|opened=2026-11-10 16:05:56
	\|pushed=2026-11-10 20:27:39		\|pushed=2026-11-11 10:13:22
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#462, as GitHub has it

2026-11-10T21:06:35Z

cryptograss/magenta#462, as GitHub has it

← Older revision		Revision as of 21:06, 10 November 2026
Line 2:		Line 2:
	\|repo=magenta		\|repo=magenta
	\|number=462		\|number=462
	\|title=Mood list: candidates on a line of their own, ≤3 a row; ramp: a Mood's name filters		\|title=Mood list: candidates on a line of their own, ≤3 a row, with people's 👍s; ramp: a Mood's name filters
	\|url=https://github.com/cryptograss/magenta/pull/462		\|url=https://github.com/cryptograss/magenta/pull/462
	\|author=magent-cryptograss		\|author=magent-cryptograss
Line 33:		Line 33:
	- Checked against a local server: the page stayed on `/ramp/`, the filter kept #interfaces' rows and hid the rest, and "every Mood" brought back all 17.		- Checked against a local server: the page stayed on `/ramp/`, the filter kept #interfaces' rows and hid the rest, and "every Mood" brought back all 17.

	Tests: `RampMoodFilterTest` is new. The who/where test now expects `data-moods`. The full suite ran 1,954 tests; its one failure was that assertion, which now passes along with `test_ramp`, `test_work_followups` and `test_tools_ask` (116 OK).		People's 👍s in the Mood (Justin, 10 Nov, 20:23Z: "let's have any 👍's on CB's show right in the mood, next to the emergent color dots, with the first two characters of the person's name, and then have hover show the whole name and blocks ago since they indicated").
			- Each candidate a merge ask names now carries `thumbs` (`tools_ask.with_thumbs`): each person's newest 👍 on its branch.
			- They're drawn right after the emergents' dots, as 👍sk, both in the Mood's merge pills and in the Mood list's candidate chips.
			- Hovering one says, for example, "skyler 👍 300 blocks ago".
			- A 👍 on an older commit is faded, and its hover adds "on an older commit".
			- Shown only for candidates with an open merge ask, since those are the ones with dots.
			- Checked by running `askGroups` in node (two 👍s, one faded). Not looked at in a browser.

			Tests: `RampMoodFilterTest` is new. The who/where test now expects `data-moods`. The full suite ran 1,954 tests; its one failure was that assertion, which now passes along with `test_ramp`, `test_work_followups` and `test_tools_ask` (116 OK). After the 👍s and a rebase onto main: the full suite ran 1,957 tests; its one failure was an assertion that didn't expect `thumbs`, now updated and passing.

	Deploy: redeploy maybelle (memory-lane); no migrations		Deploy: redeploy maybelle (memory-lane); no migrations
	Worked on by: magent, justin, in #interfaces</pre>		Worked on by: magent, justin, in #interfaces</pre>

DrivingThatTrain: cryptograss/magenta#462, as GitHub has it

2026-11-10T20:27:49Z

cryptograss/magenta#462, as GitHub has it

← Older revision		Revision as of 20:27, 10 November 2026
Line 9:		Line 9:
	\|branch=magent/cand-line-ramp-mood		\|branch=magent/cand-line-ramp-mood
	\|opened=2026-11-10 16:05:56		\|opened=2026-11-10 16:05:56
	\|pushed=2026-11-10 16:05:40		\|pushed=2026-11-10 20:27:39
	\|merged=		\|merged=
	\|closed=		\|closed=

DrivingThatTrain: cryptograss/magenta#462, as GitHub has it

2026-11-10T16:06:03Z

cryptograss/magenta#462, as GitHub has it

New page

{{PR
|repo=magenta
|number=462
|title=Mood list: candidates on a line of their own, ≤3 a row; ramp: a Mood's name filters
|url=https://github.com/cryptograss/magenta/pull/462
|author=magent-cryptograss
|state=open
|base=main
|branch=magent/cand-line-ramp-mood
|opened=2026-11-10 16:05:56
|pushed=2026-11-10 16:05:40
|merged=
|closed=
|worked_on_by=magent, justin
|moods=interfaces
|deploy=redeploy maybelle (memory-lane); no migrations
}}
<pre class="pr-body">Justin, 10 Nov (#interfaces), after #453: "Let's have them appear on the third line, after the usage metrics. And let's have at most three of them appear on a line, and break to the next line after that. Also, in the ramp view, if I click on a mood name, instead of taking me directly to that mood, I'd rather have it filter the list to show only CBs from that mood (in all of the categories - open, merged, etc)."

**Mood list**
- Candidate chips move out of the title line onto their own line, right after the usage numbers and before the people line. 🔨 and 🖥️ asks stay in the title.
- **At most three a row.** A row breaks after every third chip. A narrow nav fits fewer.
- I tried a fixed three-column grid first, but at the default nav width (189px) it cut every name to "ca…".
- **Names:** each chip shows the branch name after the owner's ("candidates", not "magent/candidates") so more fit. Hovering shows the whole ref, e.g. `magenta#451 (magent/candidates)`, and who asked.
- Checked with injected rows at nav widths 189 and 300. At 189: one or two to a row. At 300: three, then a break.

**Ramp**
- Clicking a Mood's name in "where", on an open or a merged row, now filters both tables to that Mood's candidates instead of opening the Mood.
- A line above the list says "Only candidates from #interfaces, open and merged: 7 of 17", with an "every Mood" button. Clicking the same name again also clears it.
- Ctrl- or cmd-click still opens the Mood.
- It combines with the who buttons: a row shows only if both filters let it through.
- The filter isn't remembered: it's a quick look, not a setting.
- Checked against a local server: the page stayed on `/ramp/`, the filter kept #interfaces' rows and hid the rest, and "every Mood" brought back all 17.

**Tests:** `RampMoodFilterTest` is new. The who/where test now expects `data-moods`. The full suite ran 1,954 tests; its one failure was that assertion, which now passes along with `test_ramp`, `test_work_followups` and `test_tools_ask` (116 OK).

Deploy: redeploy maybelle (memory-lane); no migrations
Worked on by: magent, justin, in #interfaces</pre>