VersionControl:PRs/rabbithole/12 - Revision history

DrivingThatTrain: cryptograss/rabbithole#12, as GitHub has it

2026-11-09T19:06:21Z

cryptograss/rabbithole#12, as GitHub has it

← Older revision		Revision as of 19:06, 9 November 2026
Line 16:		Line 16:
	\|deploy=redeploy pickipedia.		\|deploy=redeploy pickipedia.
	}}		}}
			<pre class="pr-body">Item 1 of the [player audit](https://pickipedia.xyz/wiki/26350517_Rabbithole_player_audit): a song that ended never played the next one. Track end was guessed from the clock and a `length` field Webamp's media state does not have, so trails and add-to-queue lined songs up that nothing ever reached.

			Invariant: when a song ends, the next queued song plays. By construction: the queue is Webamp's playlist. `enqueue(song)` appends to it; Webamp moves on by itself on `ended`, as a playlist does; the player watches Webamp's current track and shows the song it belongs to, and tells the shell (`onSongChange`) so title, cover, URL and card clicks catch up. The shell keeps no queue of its own, and `playNextInRabbithole` is gone. An "Up next" line under the title reads the playlist back (`onQueueChange`).

			Every track handed to Webamp now carries its title as `metaData`, so Webamp reads no ID3 tags out of the file: no second fetch of the audio from IPFS, and the "Cannot cancel a locked stream" console errors are gone with it.

			Found on the way: `openWikiPage` wired the pane's links twice (once inside `wirePaneChrome`, once after it) since 18 Oct. One click on a pane Listen button loaded its song twice, 20ms apart. That is the pair of loads behind Skyler's doubled cards; #9 made a double load harmless, this removes the double. One click on a trail queued it twice, too. Wired once now, and `enqueue` lines a song up once however often it is asked.

			Checked on pickipedia.xyz with the branch routed in: trail from Swords to Victory queues Victory once and "Up next: Victory" shows; a second trail click doesn't double it; seeking Swords to 3s before its end and letting it play, Victory came on by itself 2.8s later with its six cards, the header, and the URL following; a pane Listen click now runs its handler once (was twice). 7 new tests, 96 pass.

			Left alone, on purpose: the autoplay guard in `loadNewSong` (audit item 8) and the editor not following a song the playlist advanced to, which it already didn't for a pane Listen click.

			Deploy: redeploy pickipedia.
			Worked on by: magent, with Skyler and Justin, in #rabbithole</pre>

DrivingThatTrain: cryptograss/rabbithole#12, as GitHub has it

2026-11-06T18:05:41Z

cryptograss/rabbithole#12, as GitHub has it

← Older revision		Revision as of 18:05, 6 November 2026
Line 5:		Line 5:
	\|url=https://github.com/cryptograss/rabbithole/pull/12		\|url=https://github.com/cryptograss/rabbithole/pull/12
	\|author=magent-cryptograss		\|author=magent-cryptograss
	\|state=~~open~~		\|state=merged
	\|base=main		\|base=main
	\|branch=feat/queue-is-the-playlist		\|branch=feat/queue-is-the-playlist
	\|opened=2026-11-05 20:52:12		\|opened=2026-11-05 20:52:12
	\|pushed=2026-11-05 20:51:57		\|pushed=2026-11-05 20:51:57
	\|merged=		\|merged=2026-11-06 17:09:21
	\|closed=		\|closed=
	\|worked_on_by=magent, with skyler, justin		\|worked_on_by=magent, with skyler, justin

DrivingThatTrain: cryptograss/rabbithole#12, as GitHub has it

2026-11-05T20:52:16Z

cryptograss/rabbithole#12, as GitHub has it

New page

{{PR
|repo=rabbithole
|number=12
|title=The queue is Webamp's playlist; the chart follows its current track
|url=https://github.com/cryptograss/rabbithole/pull/12
|author=magent-cryptograss
|state=open
|base=main
|branch=feat/queue-is-the-playlist
|opened=2026-11-05 20:52:12
|pushed=2026-11-05 20:51:57
|merged=
|closed=
|worked_on_by=magent, with skyler, justin
|moods=rabbithole
|deploy=redeploy pickipedia.
}}