VersionControl:PRs/magenta/444: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#444, as GitHub has it |
cryptograss/magenta#444, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/444 | |url=https://github.com/cryptograss/magenta/pull/444 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/merge-announce | |branch=magent/merge-announce | ||
|opened=2026-11-09 04:14:46 | |opened=2026-11-09 04:14:46 | ||
|pushed=2026-11-09 04:14:39 | |pushed=2026-11-09 04:14:39 | ||
|merged= | |merged=2026-11-09 10:51:26 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin, re | |worked_on_by=magent, justin, re | ||
| Line 16: | Line 16: | ||
|deploy=redeploy maybelle | |deploy=redeploy maybelle | ||
}} | }} | ||
<pre class="pr-body">Plan section 8, the part left over: when githouse merges an order by mail, a line goes into the Mood it came from. | |||
- **What the line says:** "✓ magenta:re/foo · 1a2b3c4d merged by justin: magenta:re/foo into main". It's the same `merged` event GitHub's webhook writes for a pull request on a Mood's to-do list, so it renders and replies the same way. | |||
- **Which orders get a line:** the merge button's, which records the Mood the press came from (the ramp page counts as `ramp`), and `magenta.sh merge --mood <slug>`. | |||
- **When it's written:** when githouse next fetches the mailbox, within about 5 seconds of the merge, whether or not anyone kept the sheet open. | |||
- **Said once:** each order is claimed in the database (`MergeOrder.announced_at`, migration 0049), so when memory-lane's workers are asked at the same moment, only one writes the line. | |||
- **No line** for refused orders, or for orders with no Mood. | |||
- **It can't hold githouse up:** if writing the line fails, it's logged, and githouse still gets its orders. | |||
One overlap: if a pull request is on a Mood's to-do list and is merged from the button in that same Mood, the webhook writes its line too, so that Mood gets two lines. | |||
Tests: 2 new (said once, in the right Mood; nothing for a refusal or for no Mood). Full suite: 1800 tests, OK. | |||
Deploy: redeploy maybelle | |||
Worked on by: magent, justin, re, in #ramp</pre> | |||
Latest revision as of 16:06, 9 November 2026
| State | 🟣 merged 2026-11-09 10:51:26 |
|---|---|
| Worked on by | magent, justin, re |
| Moods | #ramp |
| Deploy | redeploy maybelle |
| Branch | magent/merge-announce → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-09 04:14:46 · 2026-11-09 04:14:39 |
Plan section 8, the part left over: when githouse merges an order by mail, a line goes into the Mood it came from. - **What the line says:** "✓ magenta:re/foo · 1a2b3c4d merged by justin: magenta:re/foo into main". It's the same `merged` event GitHub's webhook writes for a pull request on a Mood's to-do list, so it renders and replies the same way. - **Which orders get a line:** the merge button's, which records the Mood the press came from (the ramp page counts as `ramp`), and `magenta.sh merge --mood <slug>`. - **When it's written:** when githouse next fetches the mailbox, within about 5 seconds of the merge, whether or not anyone kept the sheet open. - **Said once:** each order is claimed in the database (`MergeOrder.announced_at`, migration 0049), so when memory-lane's workers are asked at the same moment, only one writes the line. - **No line** for refused orders, or for orders with no Mood. - **It can't hold githouse up:** if writing the line fails, it's logged, and githouse still gets its orders. One overlap: if a pull request is on a Mood's to-do list and is merged from the button in that same Mood, the webhook writes its line too, so that Mood gets two lines. Tests: 2 new (said once, in the right Mood; nothing for a refusal or for no Mood). Full suite: 1800 tests, OK. Deploy: redeploy maybelle Worked on by: magent, justin, re, in #ramp