VersionControl:PRs/magenta/421: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#421, as GitHub has it |
cryptograss/magenta#421, as GitHub has it |
||
| (3 intermediate revisions by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/421 | |url=https://github.com/cryptograss/magenta/pull/421 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/ramp-mentions-index | |branch=magent/ramp-mentions-index | ||
|opened=2026-11-07 15:40:55 | |opened=2026-11-07 15:40:55 | ||
|pushed=2026-11-07 | |pushed=2026-11-07 17:00:59 | ||
|merged= | |merged=2026-11-07 17:04:16 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin, re | |worked_on_by=magent, justin, re | ||
| Line 16: | Line 16: | ||
|deploy=redeploy maybelle | |deploy=redeploy maybelle | ||
}} | }} | ||
<pre class="pr-body">Follow-up to #420. On maybelle, the ramp page's mentions query ran past its 4 s budget. I checked after the deploy: the first load took 5.6 s, and the page said the mentions were missing. A failed try wasn't cached, so the page paid the 4 s again every minute. | |||
**Now** the mentions work the way `links.py` keeps the `#m-` links: | |||
- **An index of who named what**, with the two newest posts for each piece of work: | |||
- a pull request, named as `repo#N`, bare `#N` (magenta's), or its GitHub address | |||
- an owner's branch, `owner/name`, where owners are everyone here plus every prefix githouse holds a branch under | |||
- **Built in the background** over 60 days, with one regex narrowing the posts and a one-minute budget on Postgres. | |||
- **Kept up** after that from new posts only, every 30 s, and rebuilt hourly to catch imports. | |||
- **Same filters as links.py:** no tool calls, thinking, wrappers, wakes or machinery senders. | |||
- **Until the first build is in,** the page says it's reading the record and will fill in within a minute. | |||
Tests: | |||
- `refs_in`: what counts as naming something, and what doesn't (`&#124;`, colours, `#m-` links, `where/when`, unknown prefixes). | |||
- The index takes in new posts without being rebuilt. | |||
- The page while the first build runs. | |||
Full suite: 1762 tests, OK. | |||
Deploy: redeploy maybelle | |||
Worked on by: magent, justin, re, in #ramp</pre> | |||
Latest revision as of 16:06, 9 November 2026
| State | 🟣 merged 2026-11-07 17:04:16 |
|---|---|
| Worked on by | magent, justin, re |
| Moods | #ramp |
| Deploy | redeploy maybelle |
| Branch | magent/ramp-mentions-index → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 15:40:55 · 2026-11-07 17:00:59 |
Follow-up to #420. On maybelle, the ramp page's mentions query ran past its 4 s budget. I checked after the deploy: the first load took 5.6 s, and the page said the mentions were missing. A failed try wasn't cached, so the page paid the 4 s again every minute. **Now** the mentions work the way `links.py` keeps the `#m-` links: - **An index of who named what**, with the two newest posts for each piece of work: - a pull request, named as `repo#N`, bare `#N` (magenta's), or its GitHub address - an owner's branch, `owner/name`, where owners are everyone here plus every prefix githouse holds a branch under - **Built in the background** over 60 days, with one regex narrowing the posts and a one-minute budget on Postgres. - **Kept up** after that from new posts only, every 30 s, and rebuilt hourly to catch imports. - **Same filters as links.py:** no tool calls, thinking, wrappers, wakes or machinery senders. - **Until the first build is in,** the page says it's reading the record and will fill in within a minute. Tests: - `refs_in`: what counts as naming something, and what doesn't (`|`, colours, `#m-` links, `where/when`, unknown prefixes). - The index takes in new posts without being rebuilt. - The page while the first build runs. Full suite: 1762 tests, OK. Deploy: redeploy maybelle Worked on by: magent, justin, re, in #ramp