VersionControl:PRs/magenta/419: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#419, as GitHub has it |
cryptograss/magenta#419, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/419 | |url=https://github.com/cryptograss/magenta/pull/419 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=bundles-and-tasks-to-main | |branch=bundles-and-tasks-to-main | ||
|opened=2026-11-07 03:50:08 | |opened=2026-11-07 03:50:08 | ||
|pushed=2026-11-07 03:46:37 | |pushed=2026-11-07 03:46:37 | ||
|merged= | |merged=2026-11-07 03:50:27 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">#417 (instructions bundles: the newest bundles atop the section) and #418 (the tasks section) were stacked on #416, and merged into their base branches (`hooks-in-menu`, `instructions-bundles`) rather than main. Only #416 reached main, so on maybelle `/moods/tasks/` is a 404 and the menu still says "bundle segments". | |||
This carries both to main unchanged: the two commits as reviewed, plus #418's merge commit. It merges into main cleanly. 1,750 tests passed on this tree before #418 merged. | |||
My mistake: a stacked PR has to be retargeted to main once the one below it merges. Next time I'll stack only when asked, or retarget myself as each merges. | |||
Redeploy maybelle. | |||
Worked on by: magent and justin, in #interfaces</pre> | |||
Latest revision as of 16:06, 9 November 2026
| State | 🟣 merged 2026-11-07 03:50:27 |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | not said |
| Branch | bundles-and-tasks-to-main → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 03:50:08 · 2026-11-07 03:46:37 |
#417 (instructions bundles: the newest bundles atop the section) and #418 (the tasks section) were stacked on #416, and merged into their base branches (`hooks-in-menu`, `instructions-bundles`) rather than main. Only #416 reached main, so on maybelle `/moods/tasks/` is a 404 and the menu still says "bundle segments". This carries both to main unchanged: the two commits as reviewed, plus #418's merge commit. It merges into main cleanly. 1,750 tests passed on this tree before #418 merged. My mistake: a stacked PR has to be retargeted to main once the one below it merges. Next time I'll stack only when asked, or retarget myself as each merges. Redeploy maybelle. Worked on by: magent and justin, in #interfaces