VersionControl:PRs/magenta/409: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#409, as GitHub has it |
cryptograss/magenta#409, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/409 | |url=https://github.com/cryptograss/magenta/pull/409 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/person-page-fixes | |branch=magent/person-page-fixes | ||
|opened=2026-11-06 05:07:27 | |opened=2026-11-06 05:07:27 | ||
|pushed=2026-11-06 16:47:26 | |pushed=2026-11-06 16:47:26 | ||
|merged= | |merged=2026-11-07 03:41:15 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Small things seen on the live page after #405 deployed (block 26,353,591), and one way in: | |||
- **Blocks read as floats.** `BlockClock.block_at` interpolates with a float unix time, so an estimated block came back as `26324303.0`, and the person page printed "⛓ 26,324,303.0". It returns an `int` now, and the page's formatter casts too. One test pins it. | |||
- **A poster that fails to load threw.** The `<img onerror>` removed the image first and then read `this.parentNode`, which was null by then (console: `Cannot read properties of null (reading 'classList')`). The order is swapped, so the tile goes bare as intended. | |||
- **Times read as two clocks.** The server wrote every time in UTC, while the Mood page shows the browser's local time. Now the page rewrites each time on load with `toLocaleString`, the same format as moods.html; the title keeps the UTC moment. | |||
- **A way in.** On /moods/status/, each person's name in the people table links to their page. The hover card's "Their page →" stays as it was. On the wiki side, [[Template:Magenta person]] puts the link on a User: page. | |||
28 tests pass (person feed, person card, eth blocks). | |||
Redeploy maybelle. | |||
Worked on by: magent and justin, in #pickipedia-style-and-main-page</pre> | |||
Latest revision as of 16:06, 9 November 2026
| State | 🟣 merged 2026-11-07 03:41:15 |
|---|---|
| Worked on by | magent, justin |
| Moods | #pickipedia-style-and-main-page |
| Deploy | not said |
| Branch | magent/person-page-fixes → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-06 05:07:27 · 2026-11-06 16:47:26 |
Small things seen on the live page after #405 deployed (block 26,353,591), and one way in: - **Blocks read as floats.** `BlockClock.block_at` interpolates with a float unix time, so an estimated block came back as `26324303.0`, and the person page printed "⛓ 26,324,303.0". It returns an `int` now, and the page's formatter casts too. One test pins it. - **A poster that fails to load threw.** The `<img onerror>` removed the image first and then read `this.parentNode`, which was null by then (console: `Cannot read properties of null (reading 'classList')`). The order is swapped, so the tile goes bare as intended. - **Times read as two clocks.** The server wrote every time in UTC, while the Mood page shows the browser's local time. Now the page rewrites each time on load with `toLocaleString`, the same format as moods.html; the title keeps the UTC moment. - **A way in.** On /moods/status/, each person's name in the people table links to their page. The hover card's "Their page →" stays as it was. On the wiki side, [[Template:Magenta person]] puts the link on a User: page. 28 tests pass (person feed, person card, eth blocks). Redeploy maybelle. Worked on by: magent and justin, in #pickipedia-style-and-main-page