VersionControl:PRs/magenta/406: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#406, as GitHub has it |
cryptograss/magenta#406, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/406 | |url=https://github.com/cryptograss/magenta/pull/406 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=local-time | |branch=local-time | ||
|opened=2026-11-05 23:57:05 | |opened=2026-11-05 23:57:05 | ||
|pushed=2026-11-05 23:57:00 | |pushed=2026-11-05 23:57:00 | ||
|merged= | |merged=2026-11-06 16:48:26 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Justin, in #interfaces (5 Nov): "you're always confused about what time it is for me. Can I like... set my location somehow and y'all will just know?" | |||
With [pickipedia#174](https://github.com/cryptograss/pickipedia/pull/174) (`{{#timezone:Name}}`, from MediaWiki's own time offset preference), this reads it the way pronouns are read: | |||
- `emergent_powers.time_zones(entities)`: `{{#timezone:}}` for everyone on the wiki in one expand, kept an hour; only a zone this machine's zoneinfo knows, or a fixed `+HH:MM`, is kept (`zone_ok`): a preference can't carry words into a prompt. | |||
- The Mood's page carries `zones` beside `pronouns`; the people list carries each one's `zone`. | |||
- The poller's `local_time_lines` adds a line after the pronouns: "Local time, where each is now: you 18:02 (UTC+00:00); justin 13:02 (America/Chicago, UTC-05:00); skyler 11:02 (America/Los_Angeles, UTC-07:00). The hour there says whether it is their working day, their dinner or their night; for anyone not named here, don't guess." Its words are the new `local-time` line of [[Cryptograss:Emergents/Wake]] (and `poller/wake_texts.md`, the recovery copy). | |||
A preference change isn't an edit, so it shows within the hour the zones are kept. | |||
Tests: `test_mood_poller` (the line, and `local_time` on zones, offsets and junk), `test_mood_devices` (`time_zones`, `zone_ok`); the whole suite, 1,690 pass. | |||
Redeploy: hunter (the poller), maybelle (memory-lane) | |||
Worked on by: magent, justin, in #interfaces</pre> | |||
Latest revision as of 16:06, 9 November 2026
| State | 🟣 merged 2026-11-06 16:48:26 |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | not said |
| Branch | local-time → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-05 23:57:05 · 2026-11-05 23:57:00 |
Justin, in #interfaces (5 Nov): "you're always confused about what time it is for me. Can I like... set my location somehow and y'all will just know?"
With [pickipedia#174](https://github.com/cryptograss/pickipedia/pull/174) (`{{#timezone:Name}}`, from MediaWiki's own time offset preference), this reads it the way pronouns are read:
- `emergent_powers.time_zones(entities)`: `{{#timezone:}}` for everyone on the wiki in one expand, kept an hour; only a zone this machine's zoneinfo knows, or a fixed `+HH:MM`, is kept (`zone_ok`): a preference can't carry words into a prompt.
- The Mood's page carries `zones` beside `pronouns`; the people list carries each one's `zone`.
- The poller's `local_time_lines` adds a line after the pronouns: "Local time, where each is now: you 18:02 (UTC+00:00); justin 13:02 (America/Chicago, UTC-05:00); skyler 11:02 (America/Los_Angeles, UTC-07:00). The hour there says whether it is their working day, their dinner or their night; for anyone not named here, don't guess." Its words are the new `local-time` line of [[Cryptograss:Emergents/Wake]] (and `poller/wake_texts.md`, the recovery copy).
A preference change isn't an edit, so it shows within the hour the zones are kept.
Tests: `test_mood_poller` (the line, and `local_time` on zones, offsets and junk), `test_mood_devices` (`time_zones`, `zone_ok`); the whole suite, 1,690 pass.
Redeploy: hunter (the poller), maybelle (memory-lane)
Worked on by: magent, justin, in #interfaces