VersionControl:PRs/maybelle-config/294: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/maybelle-config#294, as GitHub has it |
cryptograss/maybelle-config#294, as GitHub has it |
||
| Line 16: | Line 16: | ||
|deploy=redeploy maybelle | |deploy=redeploy maybelle | ||
}} | }} | ||
<pre class="pr-body">The second deploy got halfway, then failed at the branches proxy's task (deploy log: [Cryptograss:Maybelle/deploy logs/26374126](https://pickipedia.xyz/wiki/Cryptograss:Maybelle/deploy_logs/26374126)): | |||
> Unsupported parameters for (docker_container) module: mem_limit | |||
`mem_limit` is compose's word; the docker_container module calls it `memory`. Both of my tasks used it, the proxy's and the agent's. | |||
- **The fix:** `memory: 128m` for the proxy and `memory: 4g` for the agent. | |||
- **A new check, `scripts/check_task_options.py`, now in `ci/test`.** `--syntax-check` never asks a module what options it takes, so this does. It checks every task in maybelle's, hunter's and delivery-kid's playbooks, and in the roles a play lists, against the options `ansible-doc --json` gives for its module, aliases included. `set_fact` is skipped, because its options are names the play chooses. | |||
- On production it names both `mem_limit` tasks. | |||
- Here, 24 modules check out. | |||
- It doesn't yet follow `include_role`. | |||
**What the failed deploy already did:** | |||
- `branches-net` exists, Jenkins is on it and was restarted, and both images are built. The deploy stopped before the proxy and the agent started. | |||
- Jenkins has the `branches` node, offline, because its agent hasn't started. | |||
- The `branch-tests` job isn't there. The DSL file compiles (checked with groovyc). Jenkins' log will say why it wasn't seeded. | |||
`./ci/test`: githouse 49, maybelle scripts 55, hunter 54, render_diff 5, recovery gate 5, three playbooks parse, every task takes what it says. | |||
Deploy: redeploy maybelle | |||
Worked on by: magent, justin, re, in #ramp</pre> | |||
Latest revision as of 17:06, 9 November 2026
| State | 🟣 merged 2026-11-09 01:50:57 |
|---|---|
| Worked on by | magent, justin, re |
| Moods | #ramp |
| Deploy | redeploy maybelle |
| Branch | magent/branch-tests-fix2 → production, by magent-cryptograss
|
| Opened · last pushed | 2026-11-09 01:49:52 · 2026-11-09 01:49:45 |
The second deploy got halfway, then failed at the branches proxy's task (deploy log: [Cryptograss:Maybelle/deploy logs/26374126](https://pickipedia.xyz/wiki/Cryptograss:Maybelle/deploy_logs/26374126)): > Unsupported parameters for (docker_container) module: mem_limit `mem_limit` is compose's word; the docker_container module calls it `memory`. Both of my tasks used it, the proxy's and the agent's. - **The fix:** `memory: 128m` for the proxy and `memory: 4g` for the agent. - **A new check, `scripts/check_task_options.py`, now in `ci/test`.** `--syntax-check` never asks a module what options it takes, so this does. It checks every task in maybelle's, hunter's and delivery-kid's playbooks, and in the roles a play lists, against the options `ansible-doc --json` gives for its module, aliases included. `set_fact` is skipped, because its options are names the play chooses. - On production it names both `mem_limit` tasks. - Here, 24 modules check out. - It doesn't yet follow `include_role`. **What the failed deploy already did:** - `branches-net` exists, Jenkins is on it and was restarted, and both images are built. The deploy stopped before the proxy and the agent started. - Jenkins has the `branches` node, offline, because its agent hasn't started. - The `branch-tests` job isn't there. The DSL file compiles (checked with groovyc). Jenkins' log will say why it wasn't seeded. `./ci/test`: githouse 49, maybelle scripts 55, hunter 54, render_diff 5, recovery gate 5, three playbooks parse, every task takes what it says. Deploy: redeploy maybelle Worked on by: magent, justin, re, in #ramp