VersionControl:PRs/pickipedia/171: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/pickipedia#171, as GitHub has it |
cryptograss/pickipedia#171, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/pickipedia/pull/171 | |url=https://github.com/cryptograss/pickipedia/pull/171 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=production | |base=production | ||
|branch=bundles-ask-emergent | |branch=bundles-ask-emergent | ||
|opened=2026-11-04 01:10:12 | |opened=2026-11-04 01:10:12 | ||
|pushed=2026-11-04 01:10:08 | |pushed=2026-11-04 01:10:08 | ||
|merged= | |merged=2026-11-04 01:18:54 | ||
|closed= | |closed= | ||
|worked_on_by=magent, re, justin | |worked_on_by=magent, re, justin | ||
| Line 16: | Line 16: | ||
|deploy=redeploy pickipedia | |deploy=redeploy pickipedia | ||
}} | }} | ||
<pre class="pr-body">Special:EmergentBundles sends magenta's `/api/bundles/` the emergent's name as `?emergent=` instead of `?agent=`. | |||
**Why:** the agent → emergent rename's last step, magenta#382, merged and deployed 4 Nov 01:08Z. It left `/api/bundles/` accepting `?agent=` only because this page still sent it. Once this is live, a small magenta PR can drop that last old name. | |||
**Checked:** | |||
- Live magenta already filters on `?emergent=`: `/api/bundles/?emergent=magent` returns magent's records. That has been true since magenta#364. | |||
- Links the wiki already has with `?agent=` still work. The page reads either one from its own URL. | |||
- `php -l` passes, as do `check-classes.php` and `check-bundles.php`. | |||
Found by re in #emergence (4 Nov 00:31Z): the comment saying "until it takes both" had been false since #364. | |||
Deploy: redeploy pickipedia | |||
Worked on by: magent, re, Justin, in #emergence</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-04 01:18:54 |
|---|---|
| Worked on by | magent, re, justin |
| Moods | #emergence |
| Deploy | redeploy pickipedia |
| Branch | bundles-ask-emergent → production, by magent-cryptograss
|
| Opened · last pushed | 2026-11-04 01:10:12 · 2026-11-04 01:10:08 |
Special:EmergentBundles sends magenta's `/api/bundles/` the emergent's name as `?emergent=` instead of `?agent=`. **Why:** the agent → emergent rename's last step, magenta#382, merged and deployed 4 Nov 01:08Z. It left `/api/bundles/` accepting `?agent=` only because this page still sent it. Once this is live, a small magenta PR can drop that last old name. **Checked:** - Live magenta already filters on `?emergent=`: `/api/bundles/?emergent=magent` returns magent's records. That has been true since magenta#364. - Links the wiki already has with `?agent=` still work. The page reads either one from its own URL. - `php -l` passes, as do `check-classes.php` and `check-bundles.php`. Found by re in #emergence (4 Nov 00:31Z): the comment saying "until it takes both" had been false since #364. Deploy: redeploy pickipedia Worked on by: magent, re, Justin, in #emergence