VersionControl:PRs/rabbithole/27: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#27, as GitHub has it |
cryptograss/rabbithole#27, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/27 | |url=https://github.com/cryptograss/rabbithole/pull/27 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=edit-pencil | |branch=edit-pencil | ||
|opened=2026-11-08 03:23:00 | |opened=2026-11-08 03:23:00 | ||
|pushed=2026-11-08 16:59:33 | |pushed=2026-11-08 16:59:33 | ||
|merged= | |merged=2026-11-08 17:01:24 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin, skyler | |worked_on_by=magent, justin, skyler | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Justin's beta item (#rabbithole, 7 Nov 2026): "Edit Timeline" doesn't need its own real estate in the player. | |||
The button and its row are gone. A small ✎ after the song's title opens the timeline editor; clicked again (or highlighted while open) it closes it. It sits wherever the title is: sidebar, wide bar, phone. On a sideways phone, where the title gives up its line, the heading shrinks to just the pencil and takes the grid cell the button used to have, so the editor is still reachable there. | |||
Removed: the button's markup and label logic in `App.vue`, its rules in `app.css` and stale ones in `editor.css`. | |||
Checked on the preview (rabbithole0.hunter): the pencil shows beside "August" in the sidebar, in the bar at 1440 wide, and at 844×390 (sideways phone). Clicking it opens the editor, and clicking again closes it. 159 tests pass on the branch. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Justin, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-08 17:01:24 |
|---|---|
| Worked on by | magent, justin, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | edit-pencil → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-08 03:23:00 · 2026-11-08 16:59:33 |
Justin's beta item (#rabbithole, 7 Nov 2026): "Edit Timeline" doesn't need its own real estate in the player. The button and its row are gone. A small ✎ after the song's title opens the timeline editor; clicked again (or highlighted while open) it closes it. It sits wherever the title is: sidebar, wide bar, phone. On a sideways phone, where the title gives up its line, the heading shrinks to just the pencil and takes the grid cell the button used to have, so the editor is still reachable there. Removed: the button's markup and label logic in `App.vue`, its rules in `app.css` and stale ones in `editor.css`. Checked on the preview (rabbithole0.hunter): the pencil shows beside "August" in the sidebar, in the bar at 1440 wide, and at 844×390 (sideways phone). Clicking it opens the editor, and clicking again closes it. 159 tests pass on the branch. Redeploy: pickipedia Worked on by: magent, Justin, Skyler, in #rabbithole