VersionControl:PRs/rabbithole/24: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#24, as GitHub has it |
cryptograss/rabbithole#24, as GitHub has it |
||
| (3 intermediate revisions by the same user not shown) | |||
| Line 2: | Line 2: | ||
|repo=rabbithole | |repo=rabbithole | ||
|number=24 | |number=24 | ||
|title=Bottom bar: the song | |title=Bottom bar: the song holds the left end, cards against Webamp; "Follow the solo" | ||
|url=https://github.com/cryptograss/rabbithole/pull/24 | |url=https://github.com/cryptograss/rabbithole/pull/24 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=bar-song-left | |branch=bar-song-left | ||
|opened=2026-11-07 20:15:35 | |opened=2026-11-07 20:15:35 | ||
|pushed=2026-11- | |pushed=2026-11-08 03:30:49 | ||
|merged= | |merged=2026-11-08 14:58:30 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler | |worked_on_by=magent, skyler | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Skyler, #rabbithole, 7–8 Nov 2026: on the bottom bar, the album art, song selector, follow switch, Edit button and carrot were all crammed together at the right end. Then (8 Nov 03:28Z): the art and title over the song selector on the left, and the cards next to Webamp. | |||
Now, left to right: **cover and title over the song selector**, then Webamp, then the cards right beside it, then the switch and carrot at the right. | |||
- The demo songs' selector moved into the song block, under the title, where the album's track list already was (`SongInfo.vue`). There's one selector in one place, in every layout: sidebar, bar, phone. | |||
- The follow switch now reads **Follow the solo** (it was "Auto-switch artist profiles"; Skyler agreed). It's shorter, and it says what moves the page. | |||
Checked on the preview (rabbithole0.hunter) at 1440 wide (bar), 844×390 (sideways phone: selector in its grid cell as before) and in the sidebar (selector beside the cover, under the title). 159 tests pass. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-08 14:58:30 |
|---|---|
| Worked on by | magent, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | bar-song-left → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 20:15:35 · 2026-11-08 03:30:49 |
Skyler, #rabbithole, 7–8 Nov 2026: on the bottom bar, the album art, song selector, follow switch, Edit button and carrot were all crammed together at the right end. Then (8 Nov 03:28Z): the art and title over the song selector on the left, and the cards next to Webamp. Now, left to right: **cover and title over the song selector**, then Webamp, then the cards right beside it, then the switch and carrot at the right. - The demo songs' selector moved into the song block, under the title, where the album's track list already was (`SongInfo.vue`). There's one selector in one place, in every layout: sidebar, bar, phone. - The follow switch now reads **Follow the solo** (it was "Auto-switch artist profiles"; Skyler agreed). It's shorter, and it says what moves the page. Checked on the preview (rabbithole0.hunter) at 1440 wide (bar), 844×390 (sideways phone: selector in its grid cell as before) and in the sidebar (selector beside the cover, under the title). 159 tests pass. Redeploy: pickipedia Worked on by: magent, Skyler, in #rabbithole