VersionControl:PRs/rabbithole/20: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#20, as GitHub has it |
cryptograss/rabbithole#20, as GitHub has it |
||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Skin mode has shown the article styled and the chrome naked since 18 Oct: logo missing, tabs and sidebar piled under the article (Justin, #rabbithole, 6 Nov 2026). Cause: MonoBook writes its layout against `body` and `html` (`body:not(.skin--responsive) #column-content`, `body .portlet`: 49 of its 93 layout rules), and a shadow root has neither, so those rules never matched. The article's own styles (headings, links, proposal markers, studio tables) carry no body prefix, which is why the article text was styled right all along while everything around it was not. | |||
Now, in skin mode, the two wiki stylesheets are fetched once as text, every selector's own `body`/`html` token is rewritten to `.mw-shadow-body`/`.mw-shadow-html` (`skinStyles`, in pane-html.js), the page is wrapped in those stand-ins wearing the real body's classes, and the result goes in as a `<style>`. `tbody`, `.body` and declarations are untouched; the tests say so. | |||
Checked on pickipedia.xyz with the branch's build routed in: Swords in skin mode shows the PickiPedia logo, the song/discussion/view source/history tabs, navigation, search and tools in the sidebar, the footer. 152 tests pass. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Justin, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-06 18:53:39 |
|---|---|
| Worked on by | magent, justin, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | skin-mode-body → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-06 18:07:02 · 2026-11-06 18:06:57 |
Skin mode has shown the article styled and the chrome naked since 18 Oct: logo missing, tabs and sidebar piled under the article (Justin, #rabbithole, 6 Nov 2026). Cause: MonoBook writes its layout against `body` and `html` (`body:not(.skin--responsive) #column-content`, `body .portlet`: 49 of its 93 layout rules), and a shadow root has neither, so those rules never matched. The article's own styles (headings, links, proposal markers, studio tables) carry no body prefix, which is why the article text was styled right all along while everything around it was not. Now, in skin mode, the two wiki stylesheets are fetched once as text, every selector's own `body`/`html` token is rewritten to `.mw-shadow-body`/`.mw-shadow-html` (`skinStyles`, in pane-html.js), the page is wrapped in those stand-ins wearing the real body's classes, and the result goes in as a `<style>`. `tbody`, `.body` and declarations are untouched; the tests say so. Checked on pickipedia.xyz with the branch's build routed in: Swords in skin mode shows the PickiPedia logo, the song/discussion/view source/history tabs, navigation, search and tools in the sidebar, the footer. 152 tests pass. Redeploy: pickipedia Worked on by: magent, Justin, Skyler, in #rabbithole