VersionControl:PRs/rabbithole/10: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#10, as GitHub has it |
cryptograss/rabbithole#10, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/10 | |url=https://github.com/cryptograss/rabbithole/pull/10 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=feat/manual-nav-stops-follow | |branch=feat/manual-nav-stops-follow | ||
|opened=2026-11-05 05:08:19 | |opened=2026-11-05 05:08:19 | ||
|pushed=2026-11-05 05:08:15 | |pushed=2026-11-05 05:08:15 | ||
|merged= | |merged=2026-11-06 17:09:21 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler, justin | |worked_on_by=magent, skyler, justin | ||
| Line 16: | Line 16: | ||
|deploy=pickipedia | |deploy=pickipedia | ||
}} | }} | ||
<pre class="pr-body">Justin, 4 Nov: after clicking a link, the next solo still switched the page away. Skyler agreed on 5 Nov that navigating yourself should turn following off. | |||
`stopFollowing()` unticks `#auto-switch-toggle` and fires its change event. It runs on: | |||
- a /wiki/ link in the pane | |||
- a musician card | |||
- a mini-dock initial | |||
- Back/Forward (popstate) | |||
The music's own switching goes through `navigateToMusician` directly, so it doesn't trip it. One tap on the toggle turns following back on. | |||
Checked on the live pickipedia.xyz page, with this branch's pickipedia-demo.html routed in: the toggle was on, I clicked the Justin Holmes link, the page moved to it, and the toggle was off. 85/85 vitest pass. | |||
Deploy: pickipedia | |||
Worked on by: magent, skyler, justin, in #rabbithole</pre> | |||
Latest revision as of 19:06, 9 November 2026
| State | 🟣 merged 2026-11-06 17:09:21 |
|---|---|
| Worked on by | magent, skyler, justin |
| Moods | #rabbithole |
| Deploy | pickipedia |
| Branch | feat/manual-nav-stops-follow → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-05 05:08:19 · 2026-11-05 05:08:15 |
Justin, 4 Nov: after clicking a link, the next solo still switched the page away. Skyler agreed on 5 Nov that navigating yourself should turn following off. `stopFollowing()` unticks `#auto-switch-toggle` and fires its change event. It runs on: - a /wiki/ link in the pane - a musician card - a mini-dock initial - Back/Forward (popstate) The music's own switching goes through `navigateToMusician` directly, so it doesn't trip it. One tap on the toggle turns following back on. Checked on the live pickipedia.xyz page, with this branch's pickipedia-demo.html routed in: the toggle was on, I clicked the Justin Holmes link, the page moved to it, and the toggle was off. 85/85 vitest pass. Deploy: pickipedia Worked on by: magent, skyler, justin, in #rabbithole