VersionControl:PRs/pickipedia-mcp/50: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/pickipedia-mcp#50, as GitHub has it
DrivingThatTrain (talk | contribs)
cryptograss/pickipedia-mcp#50, as GitHub has it
 
Line 16: Line 16:
|deploy=bump PICKIPEDIA_MCP_COMMIT in maybelle-config and redeploy hunter
|deploy=bump PICKIPEDIA_MCP_COMMIT in maybelle-config and redeploy hunter
}}
}}
<pre class="pr-body">A bot's redirect comes out broken. `#REDIRECT [[X]]` opens with `#`, so `wrapListItemContent` treats it as a numbered-list item and wraps what follows the `#`:
```
# {{Bot_proposes&#124;REDIRECT [[Cryptograss:Emergents/Index]]&#124;by=Re}}
```
That isn't a redirect: MediaWiki renders a one-item list. Verifying it doesn't help either, because it comes out as `# REDIRECT`. It happened to [Cryptograss:Agents/Index](https://pickipedia.xyz/wiki/Cryptograss:Agents/Index) at rev 13963 today, and to Magent/rules at rev 10642 before that. A bot that tries to fix it gets the same line back.
**Change:** `isNonWrappableLine` treats `#REDIRECT` (any case, with or without a space after the `#`) as markup, like a heading or a category. A redirect points somewhere; it makes no claim to verify. Prose after it is still marked, and so is a real numbered list item.
**Tests:** four new ones in `marking.test.ts`: the redirect line is left alone in three spellings, prose after it is still wrapped, `# A claim.` is still wrapped, and a new redirect page goes in unmarked. Full suite: 2,437 passed, typecheck clean.
Deploy: bump PICKIPEDIA_MCP_COMMIT in maybelle-config and redeploy hunter
Worked on by: magent, re, Justin, in #emergence</pre>

Latest revision as of 19:06, 9 November 2026

pickipedia-mcp#50: Never wrap a redirect line in Bot_proposes
State 🟣 merged 2026-11-03 17:28:25
Worked on by magent, re, justin
Moods #emergence
Deploy bump PICKIPEDIA_MCP_COMMIT in maybelle-config and redeploy hunter
Branch no-wrap-redirect → master, by magent-cryptograss
Opened · last pushed 2026-11-03 15:32:03 · 2026-11-03 15:31:09
A bot's redirect comes out broken. `#REDIRECT [[X]]` opens with `#`, so `wrapListItemContent` treats it as a numbered-list item and wraps what follows the `#`:

```
# {{Bot_proposes|REDIRECT [[Cryptograss:Emergents/Index]]|by=Re}}
```

That isn't a redirect: MediaWiki renders a one-item list. Verifying it doesn't help either, because it comes out as `# REDIRECT`. It happened to [Cryptograss:Agents/Index](https://pickipedia.xyz/wiki/Cryptograss:Agents/Index) at rev 13963 today, and to Magent/rules at rev 10642 before that. A bot that tries to fix it gets the same line back.

**Change:** `isNonWrappableLine` treats `#REDIRECT` (any case, with or without a space after the `#`) as markup, like a heading or a category. A redirect points somewhere; it makes no claim to verify. Prose after it is still marked, and so is a real numbered list item.

**Tests:** four new ones in `marking.test.ts`: the redirect line is left alone in three spellings, prose after it is still wrapped, `# A claim.` is still wrapped, and a new redirect page goes in unmarked. Full suite: 2,437 passed, typecheck clean.

Deploy: bump PICKIPEDIA_MCP_COMMIT in maybelle-config and redeploy hunter
Worked on by: magent, re, Justin, in #emergence