VersionControl:PRs/magenta/442: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#442, as GitHub has it |
cryptograss/magenta#442, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/442 | |url=https://github.com/cryptograss/magenta/pull/442 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=closed | ||
|base=main | |base=main | ||
|branch=magent/merged-button | |branch=magent/merged-button | ||
| Line 11: | Line 11: | ||
|pushed=2026-11-09 00:38:54 | |pushed=2026-11-09 00:38:54 | ||
|merged= | |merged= | ||
|closed= | |closed=2026-11-10 04:34:53 | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
|moods=ramp | |moods=ramp | ||
|deploy=redeploy maybelle | |deploy=redeploy maybelle | ||
}} | }} | ||
<pre class="pr-body">Justin, 9 Nov, after the first press: once the merge is complete, the buttons should become a single green "Merged". | |||
- **Merged:** "Merge now" goes away, and "Close" becomes a green "Merged ✓", which closes the sheet. | |||
- **Refused or expired:** "Merge now" goes away too. Trying again means a new order, so reopen the sheet. | |||
- **Opening the sheet again** brings back the usual "Close". | |||
The sheet's script passes `node --check`, and the merge-button tests pass (11). | |||
Deploy: redeploy maybelle | |||
Worked on by: magent, justin, in #ramp</pre> | |||
Latest revision as of 04:34, 10 November 2026
| State | 🔴 closed 2026-11-10 04:34:53 |
|---|---|
| Worked on by | magent, justin |
| Moods | #ramp |
| Deploy | redeploy maybelle |
| Branch | magent/merged-button → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-09 00:39:02 · 2026-11-09 00:38:54 |
Justin, 9 Nov, after the first press: once the merge is complete, the buttons should become a single green "Merged". - **Merged:** "Merge now" goes away, and "Close" becomes a green "Merged ✓", which closes the sheet. - **Refused or expired:** "Merge now" goes away too. Trying again means a new order, so reopen the sheet. - **Opening the sheet again** brings back the usual "Close". The sheet's script passes `node --check`, and the merge-button tests pass (11). Deploy: redeploy maybelle Worked on by: magent, justin, in #ramp