VersionControl:PRs/magenta/453: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#453, as GitHub has it |
cryptograss/magenta#453, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/453 | |url=https://github.com/cryptograss/magenta/pull/453 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/mood-list-candidates | |branch=magent/mood-list-candidates | ||
|opened=2026-11-09 17:00:20 | |opened=2026-11-09 17:00:20 | ||
|pushed=2026-11- | |pushed=2026-11-10 14:04:32 | ||
|merged= | |merged=2026-11-10 14:12:20 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
Latest revision as of 14:12, 10 November 2026
| State | 🟣 merged 2026-11-10 14:12:20 |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | redeploy maybelle (memory-lane), after #451; no migrations |
| Branch | magent/mood-list-candidates → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-09 17:00:20 · 2026-11-10 14:04:32 |
Justin, 9 Nov (#interfaces): "instead of the badge for merge (the thread), show the name of the candidate branch from the ramp that is proposed, with the emergent color dots next to it for each emergent that has approved / asked for merge." **Stacked on #451.** This builds on its per-ask list of unmerged candidates (`tools_ask.unmerged`, the `works` field). Merge #451 first; this PR then retargets to main. - **In the Mood list:** each candidate a merge ask names shows as its branch's name in a small monospace chip, cut with … after 11em. Each emergent asking for that branch adds a dot in its colour. Hovering says the name, for example `magenta#451 (magent/candidates)`, and who asked. Two emergents asking about the same branch give one chip with two dots. Tools (🔨) and redeploy (🖥️) asks show as before. - **Already merged:** once every candidate an ask names has merged, the ask shows nothing. - **Branch names:** `unmerged` now adds a pull request's branch, read from the ramp's last board through `ramp.branch_of`. That reads only the cache and never builds a board, because a build takes seconds on maybelle. Before the ramp has been drawn, a candidate shows as `repo#N`. - **"Approved":** for now the dots are the emergents' merge asks in that Mood. 👍s on the ramp come from people, so they aren't dots here. **Tests:** `test_an_ask_carries_what_it_names_not_merged_yet` now expects the branch. `test_ramp` passes (33). I checked the chip's HTML by running `askGroups` in node: one chip per branch, a dot per emergent, merged ones dropped. I haven't looked at the list itself in a browser with real asks. Deploy: redeploy maybelle (memory-lane), after #451; no migrations Worked on by: magent, justin, in #interfaces