VersionControl:PRs/magenta/461: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#461, as GitHub has it |
cryptograss/magenta#461, as GitHub has it |
||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/461 | |url=https://github.com/cryptograss/magenta/pull/461 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/name-column-2 | |branch=magent/name-column-2 | ||
|opened=2026-11-10 14:21:01 | |opened=2026-11-10 14:21:01 | ||
|pushed=2026-11-10 14:20:47 | |pushed=2026-11-10 14:20:47 | ||
|merged= | |merged=2026-11-10 15:58:20 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
Latest revision as of 15:58, 10 November 2026
| State | 🟣 merged 2026-11-10 15:58:20 |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | redeploy maybelle (memory-lane); no migrations |
| Branch | magent/name-column-2 → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-10 14:21:01 · 2026-11-10 14:20:47 |
Justin, 10 Nov (#interfaces): "459 is merged and redeployed... I'm still getting vertical names."
**What #459 missed.** The screenshot isn't a message's heading (`.who`), which #459 fixed. It's an agent **turn's** heading (`.ahead`: ▾, the robot, the name, 🔨, 🔥, ⛓, the block).
- On a phone layout (≤720px) `.ahead` is `white-space: nowrap`, so it never wraps. That's why I couldn't reproduce it at phone width.
- On a wider screen it wraps normally. Justin's must be wider, since his shows 🔥 and ⛓, which the phone layout hides.
- There, #432's `overflow-wrap: anywhere` on `main` lets the name shrink to one letter per line.
**Fix:** `main .who, main .ahead, main .runfold { overflow-wrap: normal; }`. That covers a message's heading, a turn's, and a round's.
**Checked on the live page** at 800 wide, with a magent turn's heading squeezed to 350–500px:
- `anywhere` (what's live now): the name is 11×113 px, one letter per line;
- `normal` (this PR): 44×19.
Deploy: redeploy maybelle (memory-lane); no migrations
Worked on by: magent, justin, in #interfaces