VersionControl:PRs/rabbithole/32: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/rabbithole#32, as GitHub has it
DrivingThatTrain (talk | contribs)
cryptograss/rabbithole#32, as GitHub has it
 
Line 5: Line 5:
|url=https://github.com/cryptograss/rabbithole/pull/32
|url=https://github.com/cryptograss/rabbithole/pull/32
|author=magent-cryptograss
|author=magent-cryptograss
|state=open
|state=closed
|base=main
|base=main
|branch=song-page-first
|branch=song-page-first
Line 11: Line 11:
|pushed=2026-11-08 06:05:59
|pushed=2026-11-08 06:05:59
|merged=
|merged=
|closed=
|closed=2026-11-10 19:23:31
|worked_on_by=magent, skyler
|worked_on_by=magent, skyler
|moods=rabbithole
|moods=rabbithole

Latest revision as of 19:23, 10 November 2026

rabbithole#32: Each song starts on its own page; the pane follows the solo only while playing
State 🔴 closed 2026-11-10 19:23:31
Worked on by magent, skyler
Moods #rabbithole
Deploy redeploy pickipedia after merge (with #26).
Branch song-page-first → main, by magent-cryptograss
Opened · last pushed 2026-11-08 06:06:57 · 2026-11-08 06:05:59
Skyler, 30 Oct and again 8 Nov: every song should start on its song page on the wiki, then follow the soloists as it plays. It didn't. With no `?track=` the pane opened on Justin Holmes, where the old iframe started. With one, loading the song set its first soloist, and follow-the-solo carried the pane off the song page before a note had played.

- The first song opens its Song: page (or its metadata page if there is none), linked to or not.
- One watcher, on the song and the soloist together. A new song (from the dropdown, or the queue moving on) opens its page. A change of soloist opens theirs only while playing. Both wait on following being on, so someone reading something keeps reading.

Checked on the preview: it loads on /wiki/Song:August, and picking Victory opens /wiki/Song:Victory. While playing, seeking into part 11 (Kyle's solo at 123.5) opens /wiki/Kyle_Tuttle. Tests 159/159.

Based on #26 (the selector loads songs from the wiki), so this diff is only App.vue.

Deploy: redeploy pickipedia after merge (with #26).
Worked on by: magent, skyler, in #rabbithole