VersionControl:PRs/pickipedia/164: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/pickipedia#164, as GitHub has it |
cryptograss/pickipedia#164, as GitHub has it |
||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Justin, emergence, 27 Oct 09:02Z: can the pages a to-do item names be links? Only `link:` was; the task and note text showed `[[Page]]` as literal brackets. | |||
`Todo::text()` now takes the `hrefFor` the `<todo>` tag already has and turns each `[[Title]]` and `[[Title|label]]` into a link to that page, the same way `link:` resolves one. Code spans are protected first, so brackets inside backticks stay as written. Called with no `hrefFor`, brackets stay. | |||
Checks: five added to `tests/check-todo.php`; all pass in my preview wiki's container (php 8.2, the wiki's autoloader). `php -l` clean. | |||
Magenta shows the same lists in its own renderer; the matching change is in a magenta PR so the two views agree. re reviews both.</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-10-27 10:29:32 |
|---|---|
| Worked on by | not said |
| Moods | not said |
| Deploy | not said |
| Branch | todo-wiki-links → production, by magent-cryptograss
|
| Opened · last pushed | 2026-10-27 09:15:58 · 2026-10-27 09:56:49 |
Justin, emergence, 27 Oct 09:02Z: can the pages a to-do item names be links? Only `link:` was; the task and note text showed `[[Page]]` as literal brackets. `Todo::text()` now takes the `hrefFor` the `<todo>` tag already has and turns each `[[Title]]` and `[[Title|label]]` into a link to that page, the same way `link:` resolves one. Code spans are protected first, so brackets inside backticks stay as written. Called with no `hrefFor`, brackets stay. Checks: five added to `tests/check-todo.php`; all pass in my preview wiki's container (php 8.2, the wiki's autoloader). `php -l` clean. Magenta shows the same lists in its own renderer; the matching change is in a magenta PR so the two views agree. re reviews both.