VersionControl:PRs/maybelle-config/246: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/maybelle-config#246, as GitHub has it
Tags: Manual revert Reverted
DrivingThatTrain (talk | contribs)
cryptograss/maybelle-config#246, as GitHub has it
 
(3 intermediate revisions by the same user not shown)
Line 5: Line 5:
|url=https://github.com/cryptograss/maybelle-config/pull/246
|url=https://github.com/cryptograss/maybelle-config/pull/246
|author=magent-cryptograss
|author=magent-cryptograss
|state=open
|state=closed
|base=production
|base=production
|branch=memory-lane-github-token
|branch=memory-lane-github-token
Line 11: Line 11:
|pushed=2026-10-31 17:51:15
|pushed=2026-10-31 17:51:15
|merged=
|merged=
|closed=
|closed=2026-11-07 00:40:16
|worked_on_by=magent, justin
|worked_on_by=magent, justin
|moods=interfaces
|moods=interfaces
|deploy=redeploy maybelle (after the vault has memory_lane_github_token)
|deploy=redeploy maybelle (after the vault has memory_lane_github_token)
}}
}}
<pre class="pr-body">Justin, 31 Oct in #interfaces: merge asks for #295, #299 and #318 were still showing after #317 was deployed. The deployed memory-lane is f09c222, which includes #317.
**Likely cause.** memory-lane gets no `GITHUB_TOKEN`; the token in `maybelle.yml` goes only to Jenkins. Unsigned requests are limited to 60 GitHub calls an hour per IP, and maybelle spends them on to-do ticks, merge asks, PR cards (#314, deployed in the same release), work search and status. Right now `/api/status/` shows `pickipedia_mcp.error: "could not query GitHub: HTTPError"`. The same check (`todo._merged`) run from hunter says #295, #299 and #318 are merged. I haven't seen the 403 itself, since I can't read maybelle's logs.
**Change.** If the vault has `memory_lane_github_token`, it goes into memory-lane's env as `GITHUB_TOKEN`, which `settings.GITHUB_TOKEN` already reads. If not, nothing changes.
**Needs a person.** Create a fine-grained token, read-only, with access to public repositories, add it to the vault as `memory_lane_github_token`, then redeploy maybelle. I don't recommend reusing Jenkins' token: it likely has write scope, and memory-lane only reads.
Deploy: redeploy maybelle (after the vault has memory_lane_github_token)
Worked on by: magent, Justin, in #interfaces</pre>

Latest revision as of 17:06, 9 November 2026

maybelle-config#246: memory-lane: pass a read-only GitHub token (memory_lane_github_token) when the vault has one
State 🔴 closed 2026-11-07 00:40:16
Worked on by magent, justin
Moods #interfaces
Deploy redeploy maybelle (after the vault has memory_lane_github_token)
Branch memory-lane-github-token → production, by magent-cryptograss
Opened · last pushed 2026-10-31 17:51:20 · 2026-10-31 17:51:15
Justin, 31 Oct in #interfaces: merge asks for #295, #299 and #318 were still showing after #317 was deployed. The deployed memory-lane is f09c222, which includes #317.

**Likely cause.** memory-lane gets no `GITHUB_TOKEN`; the token in `maybelle.yml` goes only to Jenkins. Unsigned requests are limited to 60 GitHub calls an hour per IP, and maybelle spends them on to-do ticks, merge asks, PR cards (#314, deployed in the same release), work search and status. Right now `/api/status/` shows `pickipedia_mcp.error: "could not query GitHub: HTTPError"`. The same check (`todo._merged`) run from hunter says #295, #299 and #318 are merged. I haven't seen the 403 itself, since I can't read maybelle's logs.

**Change.** If the vault has `memory_lane_github_token`, it goes into memory-lane's env as `GITHUB_TOKEN`, which `settings.GITHUB_TOKEN` already reads. If not, nothing changes.

**Needs a person.** Create a fine-grained token, read-only, with access to public repositories, add it to the vault as `memory_lane_github_token`, then redeploy maybelle. I don't recommend reusing Jenkins' token: it likely has write scope, and memory-lane only reads.

Deploy: redeploy maybelle (after the vault has memory_lane_github_token)
Worked on by: magent, Justin, in #interfaces