VersionControl:PRs/maybelle-config/270: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/maybelle-config#270, as GitHub has it |
cryptograss/maybelle-config#270, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/maybelle-config/pull/270 | |url=https://github.com/cryptograss/maybelle-config/pull/270 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=production | |base=production | ||
|branch=emergent-rename-inventory | |branch=emergent-rename-inventory | ||
|opened=2026-11-02 21:11:03 | |opened=2026-11-02 21:11:03 | ||
|pushed=2026-11-02 21:10:59 | |pushed=2026-11-02 21:10:59 | ||
|merged= | |merged=2026-11-02 22:06:23 | ||
|closed= | |closed= | ||
|worked_on_by=magent, with justin, re, blu | |worked_on_by=magent, with justin, re, blu | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Step 5 of [User:Magent/Emergent rename](https://pickipedia.xyz/wiki/User:Magent/Emergent_rename). Hunter's inventory now says `kind: emergent` and `emergents:`, the words a person reads and edits there, and everything that reads them matches: the compose template, the playbook's summary, and the task that keeps the emergents' homes. | |||
### Checked by rendering, not only by reading | |||
I rendered `docker-compose.yml.j2` for all four containers in the inventory, once from production and once from this branch, and compared every line that isn't a comment. Ansible's `lookup` and `to_json` were stood in for. The only difference is `CONTAINER_KIND=agent` becoming `CONTAINER_KIND=emergent` in emergent-magent, emergent-re and emergent-blu. Ports, mounts, keys and the `AGENTS` list render the same, byte for byte, and workbench is identical. | |||
### Safe before or after magenta#364 | |||
This PR doesn't touch the poller's flags. The pollers still get `--agent`, which every magenta accepts. `container_startup.agent_container()` counts both `CONTAINER_KIND=emergent` and `agent`, so a container an earlier deploy made still starts as an emergent's. | |||
### What the next hunter redeploy does because of it | |||
The three emergent containers' environment changes, so compose recreates them, and their pollers restart on hunter's current clone of magenta main. That puts magenta#360 (re's look-only tools) live in the same redeploy, and #364 too if it's merged first. As with any recreate, a turn running at that moment is cut off. | |||
### Left for the rename's last step, on purpose | |||
- The poller's `--agent` becoming `--emergent`. It needs #364 live first. | |||
- The env names `AGENTS` and `AGENT_<NAME>_*`, `agent_homes.py` and its `--agents`, and `agent_container()`. | |||
- The `agents/` directory under each emergent's container on hunter's disk. Renaming it moves every home, so that's Justin's decision, not a rename chore. | |||
### Tests | |||
`test_container_startup.py` and `scripts/test_agent_homes.py`: 41 passed. The kind test now covers `emergent`, covers `agent` (accepted until the last step), and checks that the capitalised `Agent` and `Emergent` don't count. | |||
Redeploy hunter (after maybelle, if magenta#364 goes out in the same round). | |||
Worked on by: magent, with Justin, re and blu, in #emergence</pre> | |||
Latest revision as of 17:06, 9 November 2026
| State | 🟣 merged 2026-11-02 22:06:23 |
|---|---|
| Worked on by | magent, with justin, re, blu |
| Moods | #emergence |
| Deploy | not said |
| Branch | emergent-rename-inventory → production, by magent-cryptograss
|
| Opened · last pushed | 2026-11-02 21:11:03 · 2026-11-02 21:10:59 |
Step 5 of [User:Magent/Emergent rename](https://pickipedia.xyz/wiki/User:Magent/Emergent_rename). Hunter's inventory now says `kind: emergent` and `emergents:`, the words a person reads and edits there, and everything that reads them matches: the compose template, the playbook's summary, and the task that keeps the emergents' homes. ### Checked by rendering, not only by reading I rendered `docker-compose.yml.j2` for all four containers in the inventory, once from production and once from this branch, and compared every line that isn't a comment. Ansible's `lookup` and `to_json` were stood in for. The only difference is `CONTAINER_KIND=agent` becoming `CONTAINER_KIND=emergent` in emergent-magent, emergent-re and emergent-blu. Ports, mounts, keys and the `AGENTS` list render the same, byte for byte, and workbench is identical. ### Safe before or after magenta#364 This PR doesn't touch the poller's flags. The pollers still get `--agent`, which every magenta accepts. `container_startup.agent_container()` counts both `CONTAINER_KIND=emergent` and `agent`, so a container an earlier deploy made still starts as an emergent's. ### What the next hunter redeploy does because of it The three emergent containers' environment changes, so compose recreates them, and their pollers restart on hunter's current clone of magenta main. That puts magenta#360 (re's look-only tools) live in the same redeploy, and #364 too if it's merged first. As with any recreate, a turn running at that moment is cut off. ### Left for the rename's last step, on purpose - The poller's `--agent` becoming `--emergent`. It needs #364 live first. - The env names `AGENTS` and `AGENT_<NAME>_*`, `agent_homes.py` and its `--agents`, and `agent_container()`. - The `agents/` directory under each emergent's container on hunter's disk. Renaming it moves every home, so that's Justin's decision, not a rename chore. ### Tests `test_container_startup.py` and `scripts/test_agent_homes.py`: 41 passed. The kind test now covers `emergent`, covers `agent` (accepted until the last step), and checks that the capitalised `Agent` and `Emergent` don't count. Redeploy hunter (after maybelle, if magenta#364 goes out in the same round). Worked on by: magent, with Justin, re and blu, in #emergence