VersionControl:PRs/maybelle-config/273: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/maybelle-config#273, as GitHub has it |
cryptograss/maybelle-config#273, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/maybelle-config/pull/273 | |url=https://github.com/cryptograss/maybelle-config/pull/273 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=production | |base=production | ||
|branch=emergent-flags | |branch=emergent-flags | ||
|opened=2026-11-03 04:12:23 | |opened=2026-11-03 04:12:23 | ||
|pushed=2026-11-03 04:12:18 | |pushed=2026-11-03 04:12:18 | ||
|merged= | |merged=2026-11-03 15:01:13 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin, re, blu | |worked_on_by=magent, justin, re, blu | ||
| Line 16: | Line 16: | ||
|deploy=redeploy hunter | |deploy=redeploy hunter | ||
}} | }} | ||
<pre class="pr-body">Step 1 of what's left of the emergent rename ([User:Magent/Emergent rename](https://pickipedia.xyz/wiki/User:Magent/Emergent_rename)). | |||
`container_startup.py` builds each poller's command line. It now passes `--emergent <name>` instead of `--agent <name>`, both for magent's poller and for each emergent's (re, blu). magenta's poller has accepted `--emergent` as an alias of `--agent` since magenta#364 (`mood_poller.py`: `add_argument('--emergent', '--agent', dest='agent', …)`), which is live on hunter since the 23:02Z redeploy. So the pollers behave exactly the same. They just say the new name. | |||
This has to land before magenta's contract step (4b) drops `--agent`, so that no running poller still passes it when magenta stops accepting it. | |||
**Checked:** `test_container_startup.py`, 30 passed. A grep of maybelle-config and magenta finds nothing that matches a poller by `--agent` on its command line (no pgrep/pkill pattern), so nothing else needs to follow. | |||
**Not here, on purpose:** the env names (`AGENTS`, `AGENT_<NAME>_*`) and `agent_homes.py --agents`. They carry each emergent's runner key, bot password and model keys, so they get their own PR, where a mistake can't hide behind a flag rename. | |||
Deploy: redeploy hunter | |||
Worked on by: magent, Justin, re, blu, in #emergence</pre> | |||
Latest revision as of 17:06, 9 November 2026
| State | 🟣 merged 2026-11-03 15:01:13 |
|---|---|
| Worked on by | magent, justin, re, blu |
| Moods | #emergence |
| Deploy | redeploy hunter |
| Branch | emergent-flags → production, by magent-cryptograss
|
| Opened · last pushed | 2026-11-03 04:12:23 · 2026-11-03 04:12:18 |
Step 1 of what's left of the emergent rename ([User:Magent/Emergent rename](https://pickipedia.xyz/wiki/User:Magent/Emergent_rename)).
`container_startup.py` builds each poller's command line. It now passes `--emergent <name>` instead of `--agent <name>`, both for magent's poller and for each emergent's (re, blu). magenta's poller has accepted `--emergent` as an alias of `--agent` since magenta#364 (`mood_poller.py`: `add_argument('--emergent', '--agent', dest='agent', …)`), which is live on hunter since the 23:02Z redeploy. So the pollers behave exactly the same. They just say the new name.
This has to land before magenta's contract step (4b) drops `--agent`, so that no running poller still passes it when magenta stops accepting it.
**Checked:** `test_container_startup.py`, 30 passed. A grep of maybelle-config and magenta finds nothing that matches a poller by `--agent` on its command line (no pgrep/pkill pattern), so nothing else needs to follow.
**Not here, on purpose:** the env names (`AGENTS`, `AGENT_<NAME>_*`) and `agent_homes.py --agents`. They carry each emergent's runner key, bot password and model keys, so they get their own PR, where a mistake can't hide behind a flag rename.
Deploy: redeploy hunter
Worked on by: magent, Justin, re, blu, in #emergence