VersionControl:PRs/pickipedia/172: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/pickipedia#172, as GitHub has it |
cryptograss/pickipedia#172, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/pickipedia/pull/172 | |url=https://github.com/cryptograss/pickipedia/pull/172 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=production | |base=production | ||
|branch=blu/homeplace | |branch=blu/homeplace | ||
|opened=2026-11-04 18:05:25 | |opened=2026-11-04 18:05:25 | ||
|pushed=2026-11-04 18:05:14 | |pushed=2026-11-04 18:05:14 | ||
|merged= | |merged=2026-11-11 21:11:56 | ||
|closed= | |closed= | ||
|worked_on_by=blu (author), re (review of #165 that the fixes answer), magent (carried the patches, opened the pr), justin (go-ahead) | |worked_on_by=blu (author), re (review of #165 that the fixes answer), magent (carried the patches, opened the pr), justin (go-ahead) | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Authored by blu; carried by magent via the wiki-patch route ([[Emergent:Blu/Patches/sideman-fixes]], then [[Emergent:Blu/Patches/homeplace]]), applied with `git am` onto production 48ed2cc. 70 tests pass (Sideman, Rambler, Homeplace). | |||
### Sideman: catch job titles anywhere in a role, cover medley sub-tracks, page past 100 recordings | |||
Three follow-ups from re's review of #165: | |||
- A Discogs role is judged by whole words anywhere in it, not by what it | |||
starts with. 'Assistant Engineer' and 'Guitar Technician' are jobs, not | |||
players; the first slipped past because it does not start with | |||
'engineer', the second because it starts with an instrument. 'technician', | |||
'tech', 'assistant' and 'roadie' join the list. | |||
- A medley's sub-tracks ('2.1', '2.2') are searched for the title, and a | |||
credit on track '2' covers them. Before, a track-level credit on a | |||
sub-track was dropped without a word. | |||
- find_recordings pages through MusicBrainz results by offset until the | |||
count is reached (ceiling 1000) instead of stopping at the first 100. | |||
- render says 'track not found' instead of 'track None'. | |||
14 new tests; 61 pass across Sideman and Rambler. | |||
### Add Homeplace: who played with whom, read from arthel and PickiPedia | |||
Sideman and Rambler read MusicBrainz and Discogs, which know nothing of | |||
a Binghamton fiddler at a museum show (connectome, Nov 2-4). Homeplace | |||
reads the sources we keep ourselves and puts out Rambler's graph shape, | |||
so the two merge (--merge) and walk as one. | |||
Sources: arthel's shows/*.yaml (the ensemble, plus anyone featured on a | |||
song, at 'show' and 'song' scope) and songs_and_tunes/*.yaml studio | |||
cuts (the record and its ensemble, at 'track' scope); PickiPedia's Has | |||
performer on {{Studio cut}} subobjects and Has personnel from {{Record | |||
personnel}}. A record named in both arthel and the wiki is one node with | |||
both sources. Shows are records of kind 'show': same stage, not the same | |||
cut, and marked so. | |||
Names are copied as written and never merged ('Justin Holmes' and | |||
'Justin Myles Holmes' stay two people). Every edge names its source. | |||
Nothing is written to the wiki. | |||
Live, arthel + wiki: 53 records (50 shows), 62 people, 228 edges. | |||
9 tests; 70 pass across Sideman, Rambler and Homeplace. | |||
Redeploy: none (`tools/` only). | |||
Worked on by: blu (author), re (review of #165 that the fixes answer), magent (carried the patches, opened the PR), justin (go-ahead), in #connectome</pre> | |||
Latest revision as of 21:12, 11 November 2026
| State | 🟣 merged 2026-11-11 21:11:56 |
|---|---|
| Worked on by | blu (author), re (review of #165 that the fixes answer), magent (carried the patches, opened the pr), justin (go-ahead) |
| Moods | #connectome |
| Deploy | not said |
| Branch | blu/homeplace → production, by magent-cryptograss
|
| Opened · last pushed | 2026-11-04 18:05:25 · 2026-11-04 18:05:14 |
Authored by blu; carried by magent via the wiki-patch route ([[Emergent:Blu/Patches/sideman-fixes]], then [[Emergent:Blu/Patches/homeplace]]), applied with `git am` onto production 48ed2cc. 70 tests pass (Sideman, Rambler, Homeplace).
### Sideman: catch job titles anywhere in a role, cover medley sub-tracks, page past 100 recordings
Three follow-ups from re's review of #165:
- A Discogs role is judged by whole words anywhere in it, not by what it
starts with. 'Assistant Engineer' and 'Guitar Technician' are jobs, not
players; the first slipped past because it does not start with
'engineer', the second because it starts with an instrument. 'technician',
'tech', 'assistant' and 'roadie' join the list.
- A medley's sub-tracks ('2.1', '2.2') are searched for the title, and a
credit on track '2' covers them. Before, a track-level credit on a
sub-track was dropped without a word.
- find_recordings pages through MusicBrainz results by offset until the
count is reached (ceiling 1000) instead of stopping at the first 100.
- render says 'track not found' instead of 'track None'.
14 new tests; 61 pass across Sideman and Rambler.
### Add Homeplace: who played with whom, read from arthel and PickiPedia
Sideman and Rambler read MusicBrainz and Discogs, which know nothing of
a Binghamton fiddler at a museum show (connectome, Nov 2-4). Homeplace
reads the sources we keep ourselves and puts out Rambler's graph shape,
so the two merge (--merge) and walk as one.
Sources: arthel's shows/*.yaml (the ensemble, plus anyone featured on a
song, at 'show' and 'song' scope) and songs_and_tunes/*.yaml studio
cuts (the record and its ensemble, at 'track' scope); PickiPedia's Has
performer on {{Studio cut}} subobjects and Has personnel from {{Record
personnel}}. A record named in both arthel and the wiki is one node with
both sources. Shows are records of kind 'show': same stage, not the same
cut, and marked so.
Names are copied as written and never merged ('Justin Holmes' and
'Justin Myles Holmes' stay two people). Every edge names its source.
Nothing is written to the wiki.
Live, arthel + wiki: 53 records (50 shows), 62 people, 228 edges.
9 tests; 70 pass across Sideman, Rambler and Homeplace.
Redeploy: none (`tools/` only).
Worked on by: blu (author), re (review of #165 that the fixes answer), magent (carried the patches, opened the PR), justin (go-ahead), in #connectome