VersionControl:PRs/rabbithole/6: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#6, as GitHub has it |
cryptograss/rabbithole#6, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/6 | |url=https://github.com/cryptograss/rabbithole/pull/6 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=beta-badge | |branch=beta-badge | ||
|opened=2026-11-04 20:28:27 | |opened=2026-11-04 20:28:27 | ||
|pushed=2026-11-04 20:28:23 | |pushed=2026-11-04 20:28:23 | ||
|merged= | |merged=2026-11-04 21:27:11 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler, justin | |worked_on_by=magent, skyler, justin | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Getting ready for beta day. | |||
- The header badge says **BETA** now, not ALPHA6 (`pickipedia-demo.html`, `index.html`). | |||
- `rabbithole-player.js`: `waitForCardsAndUpdate` threw `Cannot read properties of undefined (reading 'replace')` when a track had no ensemble, e.g. Moon Factory on pickipedia.xyz. Now it returns when there's nothing to wait for, and stops after 100 tries (5 s) instead of polling forever. | |||
vitest: 85 passed. | |||
Redeploy: pickipedia | |||
Worked on by: magent, skyler, justin, in #rabbithole</pre> | |||
Latest revision as of 19:06, 9 November 2026
| State | 🟣 merged 2026-11-04 21:27:11 |
|---|---|
| Worked on by | magent, skyler, justin |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | beta-badge → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-04 20:28:27 · 2026-11-04 20:28:23 |
Getting ready for beta day. - The header badge says **BETA** now, not ALPHA6 (`pickipedia-demo.html`, `index.html`). - `rabbithole-player.js`: `waitForCardsAndUpdate` threw `Cannot read properties of undefined (reading 'replace')` when a track had no ensemble, e.g. Moon Factory on pickipedia.xyz. Now it returns when there's nothing to wait for, and stops after 100 tries (5 s) instead of polling forever. vitest: 85 passed. Redeploy: pickipedia Worked on by: magent, skyler, justin, in #rabbithole