VersionControl:PRs/rabbithole/8: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#8, as GitHub has it |
cryptograss/rabbithole#8, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/8 | |url=https://github.com/cryptograss/rabbithole/pull/8 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=fix/raw-yaml-toggle | |branch=fix/raw-yaml-toggle | ||
|opened=2026-11-05 04:50:52 | |opened=2026-11-05 04:50:52 | ||
|pushed=2026-11-05 04:50:48 | |pushed=2026-11-05 04:50:48 | ||
|merged= | |merged=2026-11-05 16:25:14 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler | |worked_on_by=magent, skyler | ||
| Line 16: | Line 16: | ||
|deploy=pickipedia | |deploy=pickipedia | ||
}} | }} | ||
<pre class="pr-body">Skyler, 5 Nov: clicking **Raw YAML** in the timeline editor does nothing. | |||
Only the raw view's half of the mode toggle (`_attachRawModeListeners`) ever had a click handler. Until 75b7f8f (25 Oct) the editor opened on the raw view, so the missing list-to-raw half went unnoticed. Now `_attachEventListeners` wires it the same way: `rawMode = true; render()`. | |||
85/85 vitest pass. There's no DOM test for the editor, so this isn't checked in a browser. | |||
Deploy: pickipedia | |||
Worked on by: magent, skyler, in #rabbithole</pre> | |||
Latest revision as of 19:06, 9 November 2026
| State | 🟣 merged 2026-11-05 16:25:14 |
|---|---|
| Worked on by | magent, skyler |
| Moods | #rabbithole |
| Deploy | pickipedia |
| Branch | fix/raw-yaml-toggle → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-05 04:50:52 · 2026-11-05 04:50:48 |
Skyler, 5 Nov: clicking **Raw YAML** in the timeline editor does nothing. Only the raw view's half of the mode toggle (`_attachRawModeListeners`) ever had a click handler. Until 75b7f8f (25 Oct) the editor opened on the raw view, so the missing list-to-raw half went unnoticed. Now `_attachEventListeners` wires it the same way: `rawMode = true; render()`. 85/85 vitest pass. There's no DOM test for the editor, so this isn't checked in a browser. Deploy: pickipedia Worked on by: magent, skyler, in #rabbithole