VersionControl:PRs/rabbithole/22: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#22, as GitHub has it |
cryptograss/rabbithole#22, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/22 | |url=https://github.com/cryptograss/rabbithole/pull/22 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=pane-edit-tab | |branch=pane-edit-tab | ||
|opened=2026-11-07 02:02:36 | |opened=2026-11-07 02:02:36 | ||
|pushed=2026-11-07 02:02:31 | |pushed=2026-11-07 02:02:31 | ||
|merged= | |merged=2026-11-07 17:22:50 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler | |worked_on_by=magent, skyler | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Skyler wanted to edit a song page's text with the timeline editor open (#rabbithole, 6 Nov 2026). Until now a click on "edit" (or "history", or any Special page) inside the pane was an ordinary link, and it took the whole app to the wiki: song gone, editor gone. Those pages cannot be shown in the pane, since injected HTML runs no scripts, so they now open in a new tab and the app stays as it was. | |||
The link classification moved out of the component into `src/wiki/pane-links.js` so it can be tested: an article stays in the pane, the wiki's own pages leave for a tab, anchors and other sites are untouched. | |||
Checked on pickipedia.xyz with the branch's build routed in: Paint Exchange in skin mode, click "edit", a second tab opens on the edit form and the first still has the player and the editor. 156 tests pass. | |||
The fuller version, a text box inside the pane that saves with the reader's login, is a separate piece of work if wanted. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-07 17:22:50 |
|---|---|
| Worked on by | magent, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | pane-edit-tab → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 02:02:36 · 2026-11-07 02:02:31 |
Skyler wanted to edit a song page's text with the timeline editor open (#rabbithole, 6 Nov 2026). Until now a click on "edit" (or "history", or any Special page) inside the pane was an ordinary link, and it took the whole app to the wiki: song gone, editor gone. Those pages cannot be shown in the pane, since injected HTML runs no scripts, so they now open in a new tab and the app stays as it was. The link classification moved out of the component into `src/wiki/pane-links.js` so it can be tested: an article stays in the pane, the wiki's own pages leave for a tab, anchors and other sites are untouched. Checked on pickipedia.xyz with the branch's build routed in: Paint Exchange in skin mode, click "edit", a second tab opens on the edit form and the first still has the player and the editor. 156 tests pass. The fuller version, a text box inside the pane that saves with the reader's login, is a separate piece of work if wanted. Redeploy: pickipedia Worked on by: magent, Skyler, in #rabbithole