VersionControl:PRs/magenta/423: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#423, as GitHub has it |
cryptograss/magenta#423, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/423 | |url=https://github.com/cryptograss/magenta/pull/423 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/mergeable-tilde | |branch=magent/mergeable-tilde | ||
|opened=2026-11-07 17:24:44 | |opened=2026-11-07 17:24:44 | ||
|pushed=2026-11-07 17:24:31 | |pushed=2026-11-07 17:24:31 | ||
|merged= | |merged=2026-11-08 02:48:46 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
| Line 16: | Line 16: | ||
|deploy=redeploy maybelle | |deploy=redeploy maybelle | ||
}} | }} | ||
<pre class="pr-body">Justin, #ramp, 7 Nov: the repo:branch autocomplete only opened once you'd typed a repository's whole name and a colon. | |||
**Now** `~` at the start of a word opens githouse's branches straight away, live ones first. Whatever you type after it narrows the list by matching anywhere in `<repo>:<branch>`: `~ramp`, `~pick:foo`, `~magenta:re`. Choosing one replaces the `~` with `repo:branch `, so the `~` never appears in the post. `~/` (a home path) and `foo~bar` don't open it. The old ways (`magenta:`, `re/`) still work. | |||
Why `~` and not `.`: a `.` starts real words here all the time (`.env`, `.fresh`, `.github`), while `~` before a letter at the start of a word almost never appears in our posts. | |||
**Checked:** I ran the trigger regex and the matching in node against sample inputs (`~`, `~/workspace`, `foo~bar`, `(~re/fix`, `~magenta:re`), and the full suite passes (1763 tests). I haven't tried it in a browser; the change is two small edits to `wordAtCaret` and the mergeable filter. | |||
Deploy: redeploy maybelle | |||
Worked on by: magent, justin, in #ramp</pre> | |||
Latest revision as of 16:06, 9 November 2026
| State | 🟣 merged 2026-11-08 02:48:46 |
|---|---|
| Worked on by | magent, justin |
| Moods | #ramp |
| Deploy | redeploy maybelle |
| Branch | magent/mergeable-tilde → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 17:24:44 · 2026-11-07 17:24:31 |
Justin, #ramp, 7 Nov: the repo:branch autocomplete only opened once you'd typed a repository's whole name and a colon. **Now** `~` at the start of a word opens githouse's branches straight away, live ones first. Whatever you type after it narrows the list by matching anywhere in `<repo>:<branch>`: `~ramp`, `~pick:foo`, `~magenta:re`. Choosing one replaces the `~` with `repo:branch `, so the `~` never appears in the post. `~/` (a home path) and `foo~bar` don't open it. The old ways (`magenta:`, `re/`) still work. Why `~` and not `.`: a `.` starts real words here all the time (`.env`, `.fresh`, `.github`), while `~` before a letter at the start of a word almost never appears in our posts. **Checked:** I ran the trigger regex and the matching in node against sample inputs (`~`, `~/workspace`, `foo~bar`, `(~re/fix`, `~magenta:re`), and the full suite passes (1763 tests). I haven't tried it in a browser; the change is two small edits to `wordAtCaret` and the mergeable filter. Deploy: redeploy maybelle Worked on by: magent, justin, in #ramp