VersionControl:PRs/rabbithole/23: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#23, as GitHub has it |
cryptograss/rabbithole#23, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/23 | |url=https://github.com/cryptograss/rabbithole/pull/23 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=carrot-play | |branch=carrot-play | ||
|opened=2026-11-07 18:30:54 | |opened=2026-11-07 18:30:54 | ||
|pushed=2026-11-07 18:30:37 | |pushed=2026-11-07 18:30:37 | ||
|merged= | |merged=2026-11-08 14:57:32 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler | |worked_on_by=magent, skyler | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Skyler, #rabbithole, 7 Nov 2026: the carrot player read as a carrot with a play button stuck in it. Now the carrot *is* the play button: its orange body is the ▶, pointing right, its greens come out the left, and it passes through a circle. | |||
- **Folded sidebar:** the circle is the progress ring, so the carrot goes through where you are in the song. | |||
- **Sidebar and bar:** a plain circle; 40px in the sidebar, 56px in the bar. | |||
- **Playing:** the carrot stays a carrot, and two notches cut through its body read as pause (instead of the whole thing becoming ❚❚). | |||
One component, `CarrotButton.vue`, replaces the two CSS-drawn carrots and the bar's override block (about 190 lines of CSS gone). The ids `#mini-play-btn` and `#inline-play-btn` are kept. | |||
Checked on pickipedia.xyz with the branch's build routed in, at 1400×900: play and pause from the sidebar, the folded strip (the ring fills as it plays) and the bottom bar; the notches show while playing. 160 tests pass. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-08 14:57:32 |
|---|---|
| Worked on by | magent, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | carrot-play → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 18:30:54 · 2026-11-07 18:30:37 |
Skyler, #rabbithole, 7 Nov 2026: the carrot player read as a carrot with a play button stuck in it. Now the carrot *is* the play button: its orange body is the ▶, pointing right, its greens come out the left, and it passes through a circle. - **Folded sidebar:** the circle is the progress ring, so the carrot goes through where you are in the song. - **Sidebar and bar:** a plain circle; 40px in the sidebar, 56px in the bar. - **Playing:** the carrot stays a carrot, and two notches cut through its body read as pause (instead of the whole thing becoming ❚❚). One component, `CarrotButton.vue`, replaces the two CSS-drawn carrots and the bar's override block (about 190 lines of CSS gone). The ids `#mini-play-btn` and `#inline-play-btn` are kept. Checked on pickipedia.xyz with the branch's build routed in, at 1400×900: play and pause from the sidebar, the folded strip (the ring fills as it plays) and the bottom bar; the notches show while playing. 160 tests pass. Redeploy: pickipedia Worked on by: magent, Skyler, in #rabbithole