VersionControl:PRs/rabbithole/25: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#25, as GitHub has it |
cryptograss/rabbithole#25, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/25 | |url=https://github.com/cryptograss/rabbithole/pull/25 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=beta-polish | |branch=beta-polish | ||
|opened=2026-11-07 20:24:24 | |opened=2026-11-07 20:24:24 | ||
|pushed=2026-11-07 20:23:57 | |pushed=2026-11-07 20:23:57 | ||
|merged= | |merged=2026-11-08 16:57:50 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin, skyler | |worked_on_by=magent, justin, skyler | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Two items from Justin's beta report (#rabbithole, 7 Nov 2026, 19:15Z): | |||
- **"The search box below is furniture"**: in skin mode, MonoBook's search form was dead, because injected HTML runs no scripts, and the pane said so in a yellow note. The pane now answers the form's submit itself and searches in the pane, so the search box works and the note is gone. Searching from either box (skin or header mode) turns follow off, as any navigation a person does already did. | |||
- **Instruments spanning lines**: a card's instrument is now one unbreakable piece, so "(5-string banjo)" never splits across lines. The name can still wrap before it. | |||
Checked on the preview (rabbithole0.hunter) on Swords to Ploughshares: skin mode shows no note, and typing "Gaven Largent" + Enter in MonoBook's box lists results in the pane while the app stays put. The cards render `(fiddle)` and `(guitar)` as nowrap spans. 159 tests pass. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Justin, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-08 16:57:50 |
|---|---|
| Worked on by | magent, justin, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | beta-polish → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 20:24:24 · 2026-11-07 20:23:57 |
Two items from Justin's beta report (#rabbithole, 7 Nov 2026, 19:15Z): - **"The search box below is furniture"**: in skin mode, MonoBook's search form was dead, because injected HTML runs no scripts, and the pane said so in a yellow note. The pane now answers the form's submit itself and searches in the pane, so the search box works and the note is gone. Searching from either box (skin or header mode) turns follow off, as any navigation a person does already did. - **Instruments spanning lines**: a card's instrument is now one unbreakable piece, so "(5-string banjo)" never splits across lines. The name can still wrap before it. Checked on the preview (rabbithole0.hunter) on Swords to Ploughshares: skin mode shows no note, and typing "Gaven Largent" + Enter in MonoBook's box lists results in the pane while the app stays put. The cards render `(fiddle)` and `(guitar)` as nowrap spans. 159 tests pass. Redeploy: pickipedia Worked on by: magent, Justin, Skyler, in #rabbithole