VersionControl:PRs/rabbithole/26: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#26, as GitHub has it |
cryptograss/rabbithole#26, as GitHub has it |
||
| (One intermediate revision by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/26 | |url=https://github.com/cryptograss/rabbithole/pull/26 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=dropdown-from-wiki | |branch=dropdown-from-wiki | ||
|opened=2026-11-07 20:38:14 | |opened=2026-11-07 20:38:14 | ||
|pushed=2026-11-07 20:37:01 | |pushed=2026-11-07 20:37:01 | ||
|merged= | |merged=2026-11-08 17:01:50 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin, skyler | |worked_on_by=magent, justin, skyler | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">The beta blocker from #rabbithole, 7 Nov 2026 (write-up: https://pickipedia.xyz/wiki/26365350_Rabbithole_beta_work). | |||
The four dropdown songs (August, Silver 44, Barlow's Jig, Paint Exchange) carried hand-written copies of their charts in `demo-songs.js`. The player played those copies; the editor saved them over the wiki's `/Metadata`. So: | |||
- Justin's flourishes on August and Paint Exchange, saved to the wiki on 1 May, never fired (Gaven's dobro glow at 2:03). | |||
- Skyler's Barlow's Jig chart, saved 2 Nov, never played from the dropdown. | |||
- Saving a dropdown song from the editor would have overwritten the wiki's chart, flourishes included. | |||
Now each demo song is a name and a trackCid, loaded by `loadTrack` like a `?track=` link: one chart per song, and the one the editor saves is the one that plays. `resolveDemoSong` and ~120 lines of copied charts are gone. | |||
**Before merging:** Silver 44's wiki page is a stub, and its only chart is the copy this PR deletes. Skyler, open Silver 44 from the dropdown on the live app (pickipedia.xyz/rabbithole), hit Edit Timeline, and Save. That writes the chart to the wiki. Paint Exchange now plays the wiki's chart (Justin's, 11.75s sections) instead of the code's (20s). | |||
Checked on the preview (rabbithole0.hunter): August from the dropdown, Gaven's card gets `flourish-active` at 2:03 and again at 2:06. Paint Exchange (6 cards, 10 parts) and Barlow's Jig (Skyler's chart) load from the wiki; Silver 44 loads with no chart, as expected until it's saved. 159 tests pass. | |||
Redeploy: pickipedia | |||
Worked on by: magent, Justin, Skyler, in #rabbithole</pre> | |||
Latest revision as of 18:06, 9 November 2026
| State | 🟣 merged 2026-11-08 17:01:50 |
|---|---|
| Worked on by | magent, justin, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | dropdown-from-wiki → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 20:38:14 · 2026-11-07 20:37:01 |
The beta blocker from #rabbithole, 7 Nov 2026 (write-up: https://pickipedia.xyz/wiki/26365350_Rabbithole_beta_work). The four dropdown songs (August, Silver 44, Barlow's Jig, Paint Exchange) carried hand-written copies of their charts in `demo-songs.js`. The player played those copies; the editor saved them over the wiki's `/Metadata`. So: - Justin's flourishes on August and Paint Exchange, saved to the wiki on 1 May, never fired (Gaven's dobro glow at 2:03). - Skyler's Barlow's Jig chart, saved 2 Nov, never played from the dropdown. - Saving a dropdown song from the editor would have overwritten the wiki's chart, flourishes included. Now each demo song is a name and a trackCid, loaded by `loadTrack` like a `?track=` link: one chart per song, and the one the editor saves is the one that plays. `resolveDemoSong` and ~120 lines of copied charts are gone. **Before merging:** Silver 44's wiki page is a stub, and its only chart is the copy this PR deletes. Skyler, open Silver 44 from the dropdown on the live app (pickipedia.xyz/rabbithole), hit Edit Timeline, and Save. That writes the chart to the wiki. Paint Exchange now plays the wiki's chart (Justin's, 11.75s sections) instead of the code's (20s). Checked on the preview (rabbithole0.hunter): August from the dropdown, Gaven's card gets `flourish-active` at 2:03 and again at 2:06. Paint Exchange (6 cards, 10 parts) and Barlow's Jig (Skyler's chart) load from the wiki; Silver 44 loads with no chart, as expected until it's saved. 159 tests pass. Redeploy: pickipedia Worked on by: magent, Justin, Skyler, in #rabbithole