VersionControl:PRs/rabbithole/31: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/rabbithole#31, as GitHub has it |
cryptograss/rabbithole#31, as GitHub has it |
||
| (2 intermediate revisions by the same user not shown) | |||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/rabbithole/pull/31 | |url=https://github.com/cryptograss/rabbithole/pull/31 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=closed | ||
|base= | |base=main | ||
|branch=phone-bar | |branch=phone-bar | ||
|opened=2026-11-08 06:04:47 | |opened=2026-11-08 06:04:47 | ||
|pushed=2026-11-08 06:04:14 | |pushed=2026-11-08 06:04:14 | ||
|merged= | |merged= | ||
|closed= | |closed=2026-11-10 19:23:28 | ||
|worked_on_by=magent, skyler | |worked_on_by=magent, skyler | ||
|moods=rabbithole | |moods=rabbithole | ||
|deploy=redeploy pickipedia after merge (with #24). | |deploy=redeploy pickipedia after merge (with #24). | ||
}} | }} | ||
<pre class="pr-body">Skyler, on a phone (#rabbithole, 8 Nov 2026): the card text is too big, the follow switch wants to come in from the edge, and the sidebar leaves no room for the wiki. | |||
- A phone always gets the bottom bar, whatever was saved or put in the URL, and isn't offered the layout switch. Phone means max-width 760px, or max-height 520px for one held sideways. | |||
- On the phone bar, card names are 11px, not the desktop 14px, and the instrument is dropped: 113px beside Webamp holds a name, not both. Checked at 390×844: all six names whole. | |||
- The follow switch sits 14px in from the right edge, not 2px. | |||
Sideways (844×390) the bar takes the bottom 180px and the wiki has the rest. Based on #24 (the bar layout), so this diff is only the phone changes. Tests 159/159. | |||
Deploy: redeploy pickipedia after merge (with #24). | |||
Worked on by: magent, skyler, in #rabbithole</pre> | |||
Latest revision as of 19:23, 10 November 2026
| State | 🔴 closed 2026-11-10 19:23:28 |
|---|---|
| Worked on by | magent, skyler |
| Moods | #rabbithole |
| Deploy | redeploy pickipedia after merge (with #24). |
| Branch | phone-bar → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-08 06:04:47 · 2026-11-08 06:04:14 |
Skyler, on a phone (#rabbithole, 8 Nov 2026): the card text is too big, the follow switch wants to come in from the edge, and the sidebar leaves no room for the wiki. - A phone always gets the bottom bar, whatever was saved or put in the URL, and isn't offered the layout switch. Phone means max-width 760px, or max-height 520px for one held sideways. - On the phone bar, card names are 11px, not the desktop 14px, and the instrument is dropped: 113px beside Webamp holds a name, not both. Checked at 390×844: all six names whole. - The follow switch sits 14px in from the right edge, not 2px. Sideways (844×390) the bar takes the bottom 180px and the wiki has the rest. Based on #24 (the bar layout), so this diff is only the phone changes. Tests 159/159. Deploy: redeploy pickipedia after merge (with #24). Worked on by: magent, skyler, in #rabbithole