VersionControl:PRs/magenta/432: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#432, as GitHub has it |
cryptograss/magenta#432, as GitHub has it |
||
| (6 intermediate revisions by the same user not shown) | |||
| Line 2: | Line 2: | ||
|repo=magenta | |repo=magenta | ||
|number=432 | |number=432 | ||
|title= | |title=On a phone: menus stay on screen, every section is reachable, the thread doesn't scroll sideways | ||
|url=https://github.com/cryptograss/magenta/pull/432 | |url=https://github.com/cryptograss/magenta/pull/432 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=servers-menu-mobile | |branch=servers-menu-mobile | ||
|opened=2026-11-08 15:13:19 | |opened=2026-11-08 15:13:19 | ||
|pushed=2026-11- | |pushed=2026-11-09 22:22:50 | ||
|merged= | |merged=2026-11-10 04:33:28 | ||
|closed= | |closed= | ||
|worked_on_by=magent, skyler, justin | |worked_on_by=magent, skyler, justin | ||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Skyler, 8 Nov in #interfaces: "the green dot drop down with maybelle, Dk, and hunter is cut off in mobile - i can only see a cut off right side of it". | |||
Cause: `#stateMenu` hangs from the right edge of the dots button (`right: 0`), 370px wide. On a phone the dots sit mid-header, so the menu started at x = −173 on a 390px screen, measured on live magenta with Playwright. | |||
Fix (`moods.html`): when the menu opens, and on resize, `keepOnScreen` shifts it to lie within 10px of each side. Measured with the same function on live magenta: 390px wide −173 → 10…380; 320px −173 → 10…310; 1280px unchanged (697…1077). The whole suite, with all three fixes: 1,786 pass. | |||
Skyler, again: "same with my notifications". The bell's `#bellMenu` hung the same way: x = −103 on a 390px screen, −112 on 320px. It now calls the same `keepOnScreen` on open and on resize: measured 10…370 and 10…310. | |||
Skyler, again: "I cant seem to find tidings, polls or the options at the top anywhere". A phone hides the header's sections; tidings, polls, status and prompts were already in the account menu (your name ▾), but todo, ramp, tasks, instructions bundles and wiki hooks were nowhere. They're now in the account menu on a phone only (display: none on desktop, checked at 1280px), and the menu scrolls when taller than the screen. Checked on live magenta at 402px with the links injected: all five show and ramp opens /moods/pulls/. `test_section_nav` now holds the account menu to the header's list; it fails without the change (no todo). | |||
Skyler, again (home-screen app): "I can swipe right for way too long into infinite blank screen". `main` scrolls on y, so x was auto too, and a long unbroken link or Release CID widened it: #general to 612px and #rabbithole to 618px on a 402px phone, measured on live magenta. Now `main { overflow-x: hidden; overflow-wrap: anywhere; }`: with it injected on live, both measure 402 and nothing in the thread runs past the edge. Code blocks keep their own sideways scroll (white-space: pre doesn't wrap). | |||
Redeploy maybelle. | |||
Worked on by: magent, skyler and justin, in #interfaces</pre> | |||
Latest revision as of 04:33, 10 November 2026
| State | 🟣 merged 2026-11-10 04:33:28 |
|---|---|
| Worked on by | magent, skyler, justin |
| Moods | #interfaces |
| Deploy | not said |
| Branch | servers-menu-mobile → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-08 15:13:19 · 2026-11-09 22:22:50 |
Skyler, 8 Nov in #interfaces: "the green dot drop down with maybelle, Dk, and hunter is cut off in mobile - i can only see a cut off right side of it".
Cause: `#stateMenu` hangs from the right edge of the dots button (`right: 0`), 370px wide. On a phone the dots sit mid-header, so the menu started at x = −173 on a 390px screen, measured on live magenta with Playwright.
Fix (`moods.html`): when the menu opens, and on resize, `keepOnScreen` shifts it to lie within 10px of each side. Measured with the same function on live magenta: 390px wide −173 → 10…380; 320px −173 → 10…310; 1280px unchanged (697…1077). The whole suite, with all three fixes: 1,786 pass.
Skyler, again: "same with my notifications". The bell's `#bellMenu` hung the same way: x = −103 on a 390px screen, −112 on 320px. It now calls the same `keepOnScreen` on open and on resize: measured 10…370 and 10…310.
Skyler, again: "I cant seem to find tidings, polls or the options at the top anywhere". A phone hides the header's sections; tidings, polls, status and prompts were already in the account menu (your name ▾), but todo, ramp, tasks, instructions bundles and wiki hooks were nowhere. They're now in the account menu on a phone only (display: none on desktop, checked at 1280px), and the menu scrolls when taller than the screen. Checked on live magenta at 402px with the links injected: all five show and ramp opens /moods/pulls/. `test_section_nav` now holds the account menu to the header's list; it fails without the change (no todo).
Skyler, again (home-screen app): "I can swipe right for way too long into infinite blank screen". `main` scrolls on y, so x was auto too, and a long unbroken link or Release CID widened it: #general to 612px and #rabbithole to 618px on a 402px phone, measured on live magenta. Now `main { overflow-x: hidden; overflow-wrap: anywhere; }`: with it injected on live, both measure 402 and nothing in the thread runs past the edge. Code blocks keep their own sideways scroll (white-space: pre doesn't wrap).
Redeploy maybelle.
Worked on by: magent, skyler and justin, in #interfaces