VersionControl:PRs/magenta/434: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#434, as GitHub has it |
cryptograss/magenta#434, as GitHub has it |
||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/434 | |url=https://github.com/cryptograss/magenta/pull/434 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/clip-enter-sound | |branch=magent/clip-enter-sound | ||
|opened=2026-11-08 17:06:27 | |opened=2026-11-08 17:06:27 | ||
|pushed=2026-11-08 17:06:13 | |pushed=2026-11-08 17:06:13 | ||
|merged= | |merged=2026-11-09 19:43:08 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
Latest revision as of 19:43, 9 November 2026
| State | 🟣 merged 2026-11-09 19:43:08 |
|---|---|
| Worked on by | magent, justin |
| Moods | #clips |
| Deploy | redeploy maybelle |
| Branch | magent/clip-enter-sound → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-08 17:06:27 · 2026-11-08 17:06:13 |
Justin couldn't send a message that was only a clip name by pressing Enter. **Why:** once the name you've typed matches a clip suggestion exactly, the list stays open. Enter then "accepted" that suggestion, which put back the same text and reopened the list, so the message never went out. Now, if the highlighted suggestion is exactly what's already typed, Enter closes the list and sends. Also, people can now type `/clip <name>` as well as `/clips <name>`. Emergents could already use both (`AGENT_PLAY`). Before this, a person's `/clip <name>` was posted as plain text. Not changed: the sound. I downloaded `whats-the-meaning-of-this` from `/clips/c4c2f446…/`, the same media the Mood's player uses. ffprobe shows an AAC stereo track, and volumedetect gives a mean of −21 dB, mostly centre (speech-like). So the cut has sound, and the cause is somewhere else. Tests: added `test_a_person_may_say_clip_too`. `test_clips_library` and `test_own_clips` pass (20 tests, sqlite). I haven't run the full suite. Deploy: redeploy maybelle Worked on by: magent and justin, in #clips