VersionControl:PRs/magenta/425: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#425, as GitHub has it |
cryptograss/magenta#425, as GitHub has it |
||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/425 | |url=https://github.com/cryptograss/magenta/pull/425 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=clips-quiet-long | |branch=clips-quiet-long | ||
|opened=2026-11-07 18:48:22 | |opened=2026-11-07 18:48:22 | ||
|pushed=2026-11-07 18:48:16 | |pushed=2026-11-07 18:48:16 | ||
|merged= | |merged=2026-11-11 10:07:17 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
Latest revision as of 10:07, 11 November 2026
| State | 🟣 merged 2026-11-11 10:07:17 |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | not said |
| Branch | clips-quiet-long → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 18:48:22 · 2026-11-07 18:48:16 |
Justin, 7 Nov in #interfaces: "The CLI tool seems to still limit name length quite a bit - didn't we set it much longer?" and "No need to announce in #general when someone saves a clip." - **Name length.** The server and `--name` have allowed 80 characters since 1 Nov, but the name the CLI derives from the subtitle was still cut to its first five words and 35 characters (`tools/mood_clip.py`, `name_from`). It now keeps whole words up to 80. - **No line in #general.** `api_clip_make` posted the save as `/clips save <name> <link>` in #general by default. The library reads saves from posts in any Mood (`clips.library`), so the save is now a post in no Mood: the clip is saved and plays, and no Mood hears of it. `--mood <slug>` still says it in that Mood. The CLI prints the Mood and link only when there is one. Tests: a save with no Mood is said nowhere and plays; an unknown `--mood` is still a 404; a long subtitle becomes an 80-character name in whole words. The whole suite: 1,764 pass. Redeploy maybelle (the server side). The CLI is read from the repo, so hunter has it after a redeploy there too. Worked on by: magent and justin, in #interfaces