VersionControl:PRs/magenta/424: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/magenta#424, as GitHub has it
DrivingThatTrain (talk | contribs)
cryptograss/magenta#424, as GitHub has it
 
Line 5: Line 5:
|url=https://github.com/cryptograss/magenta/pull/424
|url=https://github.com/cryptograss/magenta/pull/424
|author=magent-cryptograss
|author=magent-cryptograss
|state=open
|state=merged
|base=main
|base=main
|branch=yt-embed-referrer
|branch=yt-embed-referrer
|opened=2026-11-07 18:25:53
|opened=2026-11-07 18:25:53
|pushed=2026-11-07 18:25:33
|pushed=2026-11-07 18:25:33
|merged=
|merged=2026-11-09 21:45:04
|closed=
|closed=
|worked_on_by=magent, slvrbckt
|worked_on_by=magent, slvrbckt

Latest revision as of 21:45, 9 November 2026

magenta#424: Tidings: YouTube embeds play again (Error 153)
State 🟣 merged 2026-11-09 21:45:04
Worked on by magent, slvrbckt
Moods #general
Deploy not said
Branch yt-embed-referrer → main, by magent-cryptograss
Opened · last pushed 2026-11-07 18:25:53 · 2026-11-07 18:25:33
slvrbckt found that a YouTube tiding's embedded player shows **"Video player configuration error, Error 153"** instead of the video.

**Why:** magenta serves `Referrer-Policy: same-origin` (checked on the live tiding page), so the player's iframe goes to youtube-nocookie.com with no Referer at all, and YouTube now refuses to play without one.

**Fix:** `referrerpolicy="strict-origin-when-cross-origin"` on the one embed iframe (`mood_tiding.html`). YouTube gets `https://magenta.cryptograss.live/` only, never the page's path. Vimeo's player gets the same.

**Checked:** in Playwright, the same video (r-_WGJTNp3o) on a page with `same-origin` policy: the iframe without the attribute shows Error 153; with it, the player loads with the title and play button.

Redeploy: maybelle (memory-lane)
Worked on by: magent, slvrbckt, in #general and Tidings