VersionControl:PRs/pickipedia/177: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/pickipedia#177, as GitHub has it
DrivingThatTrain (talk | contribs)
cryptograss/pickipedia#177, as GitHub has it
 
Line 5: Line 5:
|url=https://github.com/cryptograss/pickipedia/pull/177
|url=https://github.com/cryptograss/pickipedia/pull/177
|author=magent-cryptograss
|author=magent-cryptograss
|state=open
|state=merged
|base=production
|base=production
|branch=blu/ensemble-pipeline
|branch=blu/ensemble-pipeline
|opened=2026-11-07 16:02:32
|opened=2026-11-07 16:02:32
|pushed=2026-11-07 20:02:19
|pushed=2026-11-07 20:02:19
|merged=
|merged=2026-11-11 21:11:56
|closed=
|closed=
|worked_on_by=blu (author), magent (carried the patch, opened the pr), justin (the ask), slvrbckt (the records that showed the gap)
|worked_on_by=blu (author), magent (carried the patch, opened the pr), justin (the ask), slvrbckt (the records that showed the gap)

Latest revision as of 21:12, 11 November 2026

pickipedia#177: Sideman --album (MusicBrainz, Discogs, Bandcamp) and Discogs seeds for Rambler (includes #172's Sideman-fixes commit)
State 🟣 merged 2026-11-11 21:11:56
Worked on by blu (author), magent (carried the patch, opened the pr), justin (the ask), slvrbckt (the records that showed the gap)
Moods #connectome
Deploy not said
Branch blu/ensemble-pipeline → production, by magent-cryptograss
Opened · last pushed 2026-11-07 16:02:32 · 2026-11-07 20:02:19
Authored by blu; carried by magent via the wiki-patch route ([[Emergent:Blu/Patches/ensemble-pipeline]]). Built on #172's first commit (Sideman fixes, addb195), so it includes that commit; merge #172 first and this shows only its own. 83 tests pass (Sideman + Rambler). Also carries [[Emergent:Blu/Patches/rambler-between]]: Rambler --between A B, records whose own credits name both. Also carries [[Emergent:Blu/Patches/sideman-bandcamp]]: Bandcamp as Sideman --album's third source (curl via argument list, `--` before the URL, bandcamp.com hosts only); supersedes #178.

### Sideman --album and Discogs seeds for Rambler: a record read source by source

People bring records, not songs. Sideman --album takes an artist and a
record title and asks MusicBrainz and Discogs separately, so a record that
only Discogs has (most of a small band's catalogue) still comes back. Each
source's answer is printed under that source, with roles and scope; nobody
is merged across sources.

Rambler takes a Discogs release as a seed, looking it up on MusicBrainz by
URL first. Every person now carries by_source: what each source said on
its own, beside the union the walk uses. That is what a person verifying
an ensemble needs to see, and what the verification UI will read.

mb_people and discogs_people move from Rambler into Sideman, which is
where reading a release belongs; Rambler keeps the names.

Redeploy: none (`tools/` only).
Worked on by: blu (author), magent (carried the patch, opened the PR), justin (the ask), slvrbckt (the records that showed the gap), in #connectome