Cryptograss:Moods/rabbithole/todo: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
m Merged, says GitHub: https://github.com/cryptograss/rabbithole/pull/24, https://github.com/cryptograss/rabbithole/pull/28 |
#31, #32, #33 are stacked on branches that stay behind after their merges: retarget to main before merging (via update-page on MediaWiki MCP Server) |
||
| Line 219: | Line 219: | ||
kind: review | kind: review | ||
link: https://github.com/cryptograss/rabbithole/pull/31 | link: https://github.com/cryptograss/rabbithole/pull/31 | ||
note: "BETA. On the preview." | note: "BETA. On the preview. RETARGET FIRST: its base is bar-song-left (#24's branch, merged 14:58Z 8 Nov but not deleted), so merging as is lands it there, not on main. Edit the PR, base: main, then merge. Same for #32 (base dropdown-from-wiki) after #26, and #33 (base song-page-first) after #32. Checked by re against GitHub's API, 8 Nov ~17:00Z." | ||
- task: "Review rabbithole#32: each song starts on its Song: page; the pane follows the solo only while playing. Merge after #26." | - task: "Review rabbithole#32: each song starts on its Song: page; the pane follows the solo only while playing. Merge after #26." | ||
who: skyler, justin | who: skyler, justin | ||
Revision as of 16:55, 8 November 2026
- ☐Convert the timeline editor's rendering (src/editor/TimelineEditor.js) to Vue components; its model already is oneAfter #21 and #22 are merged, so it builds on them.
- ☐
- ☐
- ☐
- ☐Review rabbithole#25: pane search works in skin mode (no furniture note); instruments stay whole on cardsBETA. On the preview with #23 and #24.
- ☐Review rabbithole#27: Edit Timeline is a pencil on the song's titleBETA. On the preview.
- ☐
- ☐Review rabbithole#31: phones always get the bottom bar; card names fit; the follow switch off the edge. Merge after #24.BETA. On the preview. RETARGET FIRST: its base is bar-song-left (#24's branch, merged 14:58Z 8 Nov but not deleted), so merging as is lands it there, not on main. Edit the PR, base: main, then merge. Same for #32 (base dropdown-from-wiki) after #26, and #33 (base song-page-first) after #32. Checked by re against GitHub's API, 8 Nov ~17:00Z.
- ☐
- ☐
- ☐BETA: the pane's display selector (content / skin / header): one consistent style, or drop the selectorSkyler, 8 Nov 03:59Z: the selector was scaffolding; wants the real PickiPedia as the backdrop. See the next item.
- ☐Decide: Rabbithole runs on the real wiki page (gadget or extension), swapping only #content on link clicks so the music plays on, instead of rendering the wiki into a paneSkyler is for it (8 Nov 04:00Z). Same origin already.
- ☐
- ☐
- ☐
Done (38)
- ☑
- ☑
- ☑
- ☑
- ☑Read the player audit and pick which of the three structural changes to do firstFirst: one ensemble element (rabbithole#9). Next: the queue as Webamp's playlist (audit item 1).
- ☑
- ☑
- ☑
- ☑Redeploy pickipedia once #7-#14 are mergedDone 05:51 6 Nov; #10, #12, #13 still open, so another follows them.
- ☑
- ☑
- ☑
- ☑Read the framework write-up and decide: convert the shell after beta, and which framework (magent says Lit)Decided 6 Nov: Vue, now, as a PWA. Done in rabbithole#18.
- ☑Decide which shell is the product, shell.html or pickipedia-demo.html, so the other can be deletedSettled by the Vue conversion: the PWA is the product; both shells are gone in rabbithole#18.
- ☑
- ☑
- ☑
- ☑
- ☑
- ☑
- ☑Review rabbithole#22: wiki edit/history/Special links in the pane open a new tab, so the player and the timeline editor stayMarked done by its reviewer; still open on GitHub as of 7 Nov 16:18Z, so the merge is its own item below.
- ☑Merge rabbithole#21 and #22, and pickipedia#176All three open as of 7 Nov 16:18Z. #22 and pickipedia#176 are named here; #21 first, it's the one Skyler is blocked on.
- ☑Redeploy pickipedia after those mergesDone: the served build is from 17:23Z 7 Nov, after #22's merge.
- ☑Review rabbithole#23: the play button is a carrot pointing right, through a circle; notched for pauseBETA. Preview: https://rabbithole0.hunter.cryptograss.live/rabbithole/
- ☑Review rabbithole#24: on the bottom bar the song (art, title, selector) sits beside Webamp, not crammed at the rightBETA. On the preview together with #23.
- ☑BETA: flourishes back. The dropdown's four songs play a chart hardcoded in demo-songs.js, not the wiki's /Metadata, so Justin's flourishes (Gaven on August at 2:03; Paint Exchange) never fire. Load every song from the wiki.Done in rabbithole#26 (Gaven glows at 2:03 on the preview). Merge after Skyler saves Silver 44.
- ☑Restore August's chart to Justin's revision 5132: the 04:35Z saves wrote the hardcoded chart over it, and the flourishes (Gaven at 123s and 126s, Justin's gold at 165s) went with it. Open the link, Save.Done by Skyler, 04:38Z: rev 15132, same sha1 as 5132.
- ☑Review rabbithole#30: Save writes over the revision the chart was read from and no other (what overwrote August). Merge after #26.Closed 8 Nov: #26 is the fix; edit conflicts are the wiki's job (Justin).
- ☑Save Silver 44 from the live app (dropdown, Edit Timeline, Save) so its chart reaches the wiki before #26 deletes the code copyDone 8 Nov 06:25Z, rev 15149: 10 timeline entries, 5 players.
- ☑BETA: remove the 'search box below is furniture' note from the pane (Justin, reported twice)In #25: the search box works now, so the note is gone.
- ☑
- ☑BETA: tuck 'Edit Timeline' away; it doesn't need its own space in the playerIn #27: a ✎ on the song title.
- ☑BETA: say what the song dropdown is (the demo songs) or replace it with the album's tracksDecided 8 Nov (Skyler): every track with a chart on the wiki. Built in #29.
- ☑
- ☑Build the carrot being eaten as the song plays: one bite per timeline sectionSkyler's idea, 8 Nov 04:06Z. Built in #28.
- ☑
- ☑BETA: MaxListenersExceededWarning (11 close listeners), seen by Justin, reported twice; find where it's printed and fix itNot Rabbithole: a browser extension's (MetaMask's) message; Justin confirmed, 7 Nov 19:59Z.