VersionControl:PRs/magenta/442: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/magenta#442, as GitHub has it
ย 
DrivingThatTrain (talk | contribs)
cryptograss/magenta#442, as GitHub has it
Line 16: Line 16:
|deploy=redeploy maybelle
|deploy=redeploy maybelle
}}
}}
<pre class="pr-body">Justin, 9 Nov, after the first press: once the merge is complete, the buttons should become a single green "Merged".
- **Merged:** "Merge now" goes away, and "Close" becomes a green "Merged โœ“", which closes the sheet.
- **Refused or expired:** "Merge now" goes away too. Trying again means a new order, so reopen the sheet.
- **Opening the sheet again** brings back the usual "Close".
The sheet's script passes `node --check`, and the merge-button tests pass (11).
Deploy: redeploy maybelle
Worked on by: magent, justin, in #ramp</pre>

Revision as of 16:06, 9 November 2026

magenta#442: Merge sheet: one green Merged button once it's merged
State ๐ŸŸข open
Worked on by magent, justin
Moods #ramp
Deploy redeploy maybelle
Branch magent/merged-button โ†’ main, by magent-cryptograss
Opened ยท last pushed 2026-11-09 00:39:02 ยท 2026-11-09 00:38:54
Justin, 9 Nov, after the first press: once the merge is complete, the buttons should become a single green "Merged".

- **Merged:** "Merge now" goes away, and "Close" becomes a green "Merged โœ“", which closes the sheet.
- **Refused or expired:** "Merge now" goes away too. Trying again means a new order, so reopen the sheet.
- **Opening the sheet again** brings back the usual "Close".

The sheet's script passes `node --check`, and the merge-button tests pass (11).

Deploy: redeploy maybelle
Worked on by: magent, justin, in #ramp