VersionControl:PRs/magenta/431: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#431, as GitHub has it |
cryptograss/magenta#431, as GitHub has it |
||
| Line 16: | Line 16: | ||
|deploy= | |deploy= | ||
}} | }} | ||
<pre class="pr-body">Justin, 8 Nov in #interfaces: "if I press up arrow in the composer, I want it to go to edit my last message, and if it's not done sending yet, I want it to stop sending and not post until I edit it. Also, when editing, enter key needs to save." | |||
In `moods.html`: | |||
- **↑ in an empty composer** opens your newest message in this Mood that you may still edit (your own, from the web, within a day), scrolled into view. | |||
- **↑ while a send is on its way** stops it (`AbortController` on the `/say/` fetch). The faint pending line goes, the words come back in the box, and a note says "Stopped: not sent." If the server had already taken it in the moment before the stop, that message opens for editing instead, and the box is cleared so it can't be sent twice. | |||
- **↑ while a send is waiting** on a picture upload or a voice memo (caret at the start) stops the waiting; the words stay in the box. | |||
- **In the edit box**, Enter saves, as Enter sends in the composer (touch screens keep Enter as a new line, as the composer does); Ctrl/Shift+Enter makes a new line; Esc cancels. After saving or cancelling, focus goes back to the composer. | |||
- ↑ still moves the caret when there's text in the box, and still belongs to the @-suggestions when they're open. | |||
Checked in Chromium via Playwright against a local memory-lane with a signed-in test device: | |||
1. ↑ opened "hello there" for editing; | |||
2. Enter saved it as "hello there, edited", the edit box closed, and focus returned to the composer; | |||
3. a send delayed 5 s by the test, stopped by ↑: the box held "second, slow" again, the pending line was gone; | |||
4. after the delay, the thread had no "second, slow": nothing was posted. | |||
The whole suite: 1,785 pass. | |||
Redeploy maybelle. | |||
Worked on by: magent and justin, in #interfaces</pre> | |||
Revision as of 16:06, 9 November 2026
| State | 🟢 open |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | not said |
| Branch | composer-up-edit → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-08 15:06:39 · 2026-11-08 15:06:27 |
Justin, 8 Nov in #interfaces: "if I press up arrow in the composer, I want it to go to edit my last message, and if it's not done sending yet, I want it to stop sending and not post until I edit it. Also, when editing, enter key needs to save." In `moods.html`: - **↑ in an empty composer** opens your newest message in this Mood that you may still edit (your own, from the web, within a day), scrolled into view. - **↑ while a send is on its way** stops it (`AbortController` on the `/say/` fetch). The faint pending line goes, the words come back in the box, and a note says "Stopped: not sent." If the server had already taken it in the moment before the stop, that message opens for editing instead, and the box is cleared so it can't be sent twice. - **↑ while a send is waiting** on a picture upload or a voice memo (caret at the start) stops the waiting; the words stay in the box. - **In the edit box**, Enter saves, as Enter sends in the composer (touch screens keep Enter as a new line, as the composer does); Ctrl/Shift+Enter makes a new line; Esc cancels. After saving or cancelling, focus goes back to the composer. - ↑ still moves the caret when there's text in the box, and still belongs to the @-suggestions when they're open. Checked in Chromium via Playwright against a local memory-lane with a signed-in test device: 1. ↑ opened "hello there" for editing; 2. Enter saved it as "hello there, edited", the edit box closed, and focus returned to the composer; 3. a send delayed 5 s by the test, stopped by ↑: the box held "second, slow" again, the pending line was gone; 4. after the delay, the thread had no "second, slow": nothing was posted. The whole suite: 1,785 pass. Redeploy maybelle. Worked on by: magent and justin, in #interfaces