VersionControl:PRs/magenta/416: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/magenta#416, as GitHub has it
 
DrivingThatTrain (talk | contribs)
cryptograss/magenta#416, as GitHub has it
 
Line 16: Line 16:
|deploy=
|deploy=
}}
}}
<pre class="pr-body">Justin, 7 Nov in #interfaces: "Can I see all the hooks as a page under the chevron in the top?"
- `/moods/hooks/` is a section of the one page, like status, todo and verify: listed under the ▾ as "wiki hooks", framed with `?embed=1`, loaded fresh again when stale (a data section), and the whole page when opened by its address.
- The template is renamed `mood_wiki_hooks.html` → `mood_hooks.html` (the sections' naming), with the same top bar and in-frame link handling as verify. Every section page's bar links it.
- `/wiki-hooks/` and `/api/wiki-hooks/` are unchanged, so links already given and hunter's poller keep working.
Tests: the section-nav test covers hooks; the hooks test checks the framed page, its SAMEORIGIN frame header, and the menu link on the whole page. The whole suite: 1,748 pass.
Redeploy maybelle.
Worked on by: magent and justin, in #interfaces</pre>

Latest revision as of 16:06, 9 November 2026

magenta#416: Wiki hooks as a section under the ▾
State 🟣 merged 2026-11-07 03:42:13
Worked on by magent, justin
Moods #interfaces
Deploy not said
Branch hooks-in-menu → main, by magent-cryptograss
Opened · last pushed 2026-11-07 03:36:17 · 2026-11-07 03:36:13
Justin, 7 Nov in #interfaces: "Can I see all the hooks as a page under the chevron in the top?"

- `/moods/hooks/` is a section of the one page, like status, todo and verify: listed under the ▾ as "wiki hooks", framed with `?embed=1`, loaded fresh again when stale (a data section), and the whole page when opened by its address.
- The template is renamed `mood_wiki_hooks.html` → `mood_hooks.html` (the sections' naming), with the same top bar and in-frame link handling as verify. Every section page's bar links it.
- `/wiki-hooks/` and `/api/wiki-hooks/` are unchanged, so links already given and hunter's poller keep working.

Tests: the section-nav test covers hooks; the hooks test checks the framed page, its SAMEORIGIN frame header, and the menu link on the whole page. The whole suite: 1,748 pass.

Redeploy maybelle.
Worked on by: magent and justin, in #interfaces