VersionControl:PRs/rabbithole/29: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/rabbithole#29, as GitHub has it
 
DrivingThatTrain (talk | contribs)
cryptograss/rabbithole#29, as GitHub has it
Line 16: Line 16:
|deploy=redeploy pickipedia after merge (with #26).
|deploy=redeploy pickipedia after merge (with #26).
}}
}}
<pre class="pr-body">Justin asked (#rabbithole, 7 Nov): what are the dropdown's songs, and why those? They were four songs hardcoded in demo-songs.js. Skyler and magent agreed (8 Nov) to list what's charted instead.
- `chartedTracks()` (wiki/api.js) lists every Release /Metadata page, keeps the ones whose timeline has more than one entry, and reads each track's title and its album's title. That's three requests with a few dozen pages. A song joins the list as soon as someone charts it.
- The selector shows the song that is loaded, whatever loaded it, and lists that song even before it has a chart. Songs sit under their album's name, each option only a title.
- The four-song list is gone. `DEFAULT_TRACK` (August) is what the app opens on.
Today that's seven songs: August, Barlows, Cicada Song, Drowsy Maggie, Paint Exchange, Swords to Ploughshares, Victory. Silver 44 isn't there yet: its /Metadata page is a stub until Skyler saves it.
Stacked on #26: merge #26 first, and this diff shrinks to its own two commits. Checked on the preview (the selector's options read in the browser). Tests 162/162, build clean.
Deploy: redeploy pickipedia after merge (with #26).
Worked on by: magent, skyler, justin, in #rabbithole</pre>

Revision as of 18:06, 9 November 2026

rabbithole#29: The song selector lists every track with a chart on the wiki
State 🟢 open
Worked on by magent, skyler, justin
Moods #rabbithole
Deploy redeploy pickipedia after merge (with #26).
Branch charted-songs → main, by magent-cryptograss
Opened · last pushed 2026-11-08 04:31:40 · 2026-11-08 04:31:21
Justin asked (#rabbithole, 7 Nov): what are the dropdown's songs, and why those? They were four songs hardcoded in demo-songs.js. Skyler and magent agreed (8 Nov) to list what's charted instead.

- `chartedTracks()` (wiki/api.js) lists every Release /Metadata page, keeps the ones whose timeline has more than one entry, and reads each track's title and its album's title. That's three requests with a few dozen pages. A song joins the list as soon as someone charts it.
- The selector shows the song that is loaded, whatever loaded it, and lists that song even before it has a chart. Songs sit under their album's name, each option only a title.
- The four-song list is gone. `DEFAULT_TRACK` (August) is what the app opens on.

Today that's seven songs: August, Barlows, Cicada Song, Drowsy Maggie, Paint Exchange, Swords to Ploughshares, Victory. Silver 44 isn't there yet: its /Metadata page is a stub until Skyler saves it.

Stacked on #26: merge #26 first, and this diff shrinks to its own two commits. Checked on the preview (the selector's options read in the browser). Tests 162/162, build clean.

Deploy: redeploy pickipedia after merge (with #26).
Worked on by: magent, skyler, justin, in #rabbithole