VersionControl:PRs/magenta/456: Difference between revisions

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
DrivingThatTrain (talk | contribs)
cryptograss/magenta#456, as GitHub has it
 
DrivingThatTrain (talk | contribs)
cryptograss/magenta#456, as GitHub has it
Line 9: Line 9:
|branch=magent/voice-ask-pace
|branch=magent/voice-ask-pace
|opened=2026-11-09 23:05:24
|opened=2026-11-09 23:05:24
|pushed=2026-11-09 23:05:11
|pushed=2026-11-09 23:06:35
|merged=
|merged=
|closed=
|closed=

Revision as of 23:06, 9 November 2026

magenta#456: Read aloud: an ask at the end is the narrator's line, not slow-played tag words
State 🟢 open
Worked on by magent, justin
Moods #interfaces
Deploy redeploy maybelle (memory-lane); no migrations
Branch magent/voice-ask-pace → main, by magent-cryptograss
Opened · last pushed 2026-11-09 23:05:24 · 2026-11-09 23:06:35
Justin, 9 Nov (#interfaces): "the message after that read slowly, like as if it wasn't respecting the words per minute directive." This is the cause of item 6 from his 8 Nov memo, where later clips seemed slower.

**What the record shows.** These are the `heard` rows for magent's message 80170b4a, from Justin's Chrome PWA:
- Piece 1: pace 136, played at 1.61×, which is his 220 a minute.
- Piece 2: pace **240**, played at **0.92×**.

240 is the clamp's ceiling, so the page measured piece 2 as far faster than the voice speaks, then slowed it down.

**Why.** Piece 2 was "I checked that logic outside the page but haven't seen it on a phone." followed by `<merge to="magenta#455, voice bar still while recording"/>`.
- The page counts the words of what it sent: 21.
- ElevenLabs spoke only 14 of them. The tag wasn't read aloud.
- Asks always come at the end of a message, so the last piece is the one played slow.

**Fix** (in `voice.script_for`):
- Asks at the end (`trailing_asks`) are read the way the page shows them, as an aside in the narrator's voice (#454): "requested a merge for magenta number 455, voice bar still while recording".
- Any other ask or gesture tag inside the message (`<merge/> <deploy/> <tools/> <react/> <wait/> <take/> <silent/>`) is dropped from what's read.

**Not fixed here.** re's message 554bc9c2 was reported at rate 1.0 with pace 0, meaning the page couldn't read the clip's pace when it reported. That's a different path. It may be reported after the player had moved on, but I haven't confirmed that.

**Tests:** two new tests in `test_readback_pieces`: an ask becomes the narrator's aside, and a gesture in mid-message isn't read. Full suite: 1,910 ran. The only failures are the two `ReleaseTorrentTest` tests that re's branch `re/tiding-torrent-test-url` fixes on main.

Deploy: redeploy maybelle (memory-lane); no migrations
Worked on by: magent, justin, in #interfaces