VersionControl:PRs/magenta/455: Difference between revisions
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
cryptograss/magenta#455, as GitHub has it |
cryptograss/magenta#455, as GitHub has it |
||
| Line 5: | Line 5: | ||
|url=https://github.com/cryptograss/magenta/pull/455 | |url=https://github.com/cryptograss/magenta/pull/455 | ||
|author=magent-cryptograss | |author=magent-cryptograss | ||
|state= | |state=merged | ||
|base=main | |base=main | ||
|branch=magent/voice-bar-recording | |branch=magent/voice-bar-recording | ||
|opened=2026-11-09 23:00:13 | |opened=2026-11-09 23:00:13 | ||
|pushed=2026-11-09 22:59:59 | |pushed=2026-11-09 22:59:59 | ||
|merged= | |merged=2026-11-10 04:32:34 | ||
|closed= | |closed= | ||
|worked_on_by=magent, justin | |worked_on_by=magent, justin | ||
Latest revision as of 04:32, 10 November 2026
| State | 🟣 merged 2026-11-10 04:32:34 |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | redeploy maybelle (memory-lane); no migrations |
| Branch | magent/voice-bar-recording → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-09 23:00:13 · 2026-11-09 22:59:59 |
Justin, 9 Nov (#interfaces), recording a voice memo in voice mode on his phone: the top line still flickers after #441. **Why #441 missed it:** - #441 stopped the slide-in from replaying by comparing the top bar's whole HTML with the last second's. - While recording, that bar reads "recording voice memo (0:05)…". The clock changes every second, so the comparison never matched and the bar slid in again each tick. An upload's percent did the same. - The case #441 fixed and tested was the "heard" bar while an agent's clock ticks elsewhere. **Fix:** - The comparison now uses what the bar *is*: `memo:<state>` while a memo is in progress (recording, uploading, transcribing, sending), and the heard message's identity otherwise. - The bar still slides in when the state changes: recording, then saving, then transcribing, then sent. **Checked:** I ran the rendering block in node. Recording at 0:01, 0:02, 0:03: the first slides in and the next two are `still`. Uploading at 10% then 40%: the first slides in and the second is `still`. The page's scripts parse. I couldn't record a memo in a headless browser, so I haven't seen it on a phone. Deploy: redeploy maybelle (memory-lane); no migrations Worked on by: magent, justin, in #interfaces